You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/05 18:40:14 UTC
[GitHub] [lucene-solr] thelabdude opened a new pull request #2178: SOLR-15058: Enforce node_name contains colon and port and find first underscore after colon to parse context
thelabdude opened a new pull request #2178:
URL: https://github.com/apache/lucene-solr/pull/2178
# Description
See: https://issues.apache.org/jira/browse/SOLR-15058
# Solution
The current impl. of `Utils#getBaseUrlForNodeName` would create the wrong URL if the hostname contains an underscore `_`. However, the `ZkController#generateNodeName` function always creates node names with a `:` and port number, so this PR updates the `Utils#getBaseUrlForNodeName` to enforce the presence of a `:` colon and then finds the position of the the first `_` after the colon to find the context. The bulk of the changes here are updates to tests that were using node name values that don't adhere to the format created by `ZkController#generateNodeName`.
# Tests
Updated existing unit test to ensure hostnames with `_` are parsed correctly. Updated various unit tests that were using node name values that didn't adhere to the format used by `ZkController#generateNodeName`.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] thelabdude merged pull request #2178: SOLR-15058: Enforce node_name contains colon and port and find first underscore after colon to parse context
Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #2178:
URL: https://github.com/apache/lucene-solr/pull/2178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org