You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/10 09:33:22 UTC

[GitHub] [cloudstack] slavkap commented on a change in pull request #6057: server: mark volume snapshots as Destroyed if it does not exist on primary and secondary storage when delete a volume

slavkap commented on a change in pull request #6057:
URL: https://github.com/apache/cloudstack/pull/6057#discussion_r823518926



##########
File path: engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
##########
@@ -468,6 +471,7 @@ public Void deleteVolumeCallback(AsyncCallbackDispatcher<VolumeServiceImpl, Comm
                         _snapshotStoreDao.remove(snapStoreVo.getId());

Review comment:
       Hi @weizhouapache, isn't it better to keep the info in the DB for the snapshots and update the State as `Destroyed`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org