You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/19 02:02:53 UTC
Review Request 15662: Added back the sleep call in the command executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15662/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-243 and MESOS-820
https://issues.apache.org/jira/browse/MESOS-243
https://issues.apache.org/jira/browse/MESOS-820
Repository: mesos-git
Description
-------
It turns out the fix in MESOS-243 was not quite enough to ensure the outstanding status updates are flushed prior to exiting. This is because the call to ProcessBase::send is asynchronous.
Diffs
-----
src/launcher/executor.cpp 2e53bb80d51bd6d83e4a44a09df0978fb2416dea
Diff: https://reviews.apache.org/r/15662/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 15662: Added back the sleep call in the command executor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15662/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 1:33 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
MESOS-821 was the same issue.
Bugs: MESOS-243, MESOS-820 and MESOS-821
https://issues.apache.org/jira/browse/MESOS-243
https://issues.apache.org/jira/browse/MESOS-820
https://issues.apache.org/jira/browse/MESOS-821
Repository: mesos-git
Description
-------
It turns out the fix in MESOS-243 was not quite enough to ensure the outstanding status updates are flushed prior to exiting. This is because the call to ProcessBase::send is asynchronous.
Diffs
-----
src/launcher/executor.cpp 2e53bb80d51bd6d83e4a44a09df0978fb2416dea
Diff: https://reviews.apache.org/r/15662/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 15662: Added back the sleep call in the command executor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15662/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 1:30 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
MESOS-819 exposes an unrelated issue.
Bugs: MESOS-243 and MESOS-820
https://issues.apache.org/jira/browse/MESOS-243
https://issues.apache.org/jira/browse/MESOS-820
Repository: mesos-git
Description
-------
It turns out the fix in MESOS-243 was not quite enough to ensure the outstanding status updates are flushed prior to exiting. This is because the call to ProcessBase::send is asynchronous.
Diffs
-----
src/launcher/executor.cpp 2e53bb80d51bd6d83e4a44a09df0978fb2416dea
Diff: https://reviews.apache.org/r/15662/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 15662: Added back the sleep call in the command executor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15662/
-----------------------------------------------------------
(Updated Nov. 19, 2013, 1:22 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Linked MESOS-819.
Bugs: MESOS-243, MESOS-819 and MESOS-820
https://issues.apache.org/jira/browse/MESOS-243
https://issues.apache.org/jira/browse/MESOS-819
https://issues.apache.org/jira/browse/MESOS-820
Repository: mesos-git
Description
-------
It turns out the fix in MESOS-243 was not quite enough to ensure the outstanding status updates are flushed prior to exiting. This is because the call to ProcessBase::send is asynchronous.
Diffs
-----
src/launcher/executor.cpp 2e53bb80d51bd6d83e4a44a09df0978fb2416dea
Diff: https://reviews.apache.org/r/15662/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 15662: Added back the sleep call in the command executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15662/#review29091
-----------------------------------------------------------
Ship it!
Can you also link MESOS-819 ?
- Vinod Kone
On Nov. 19, 2013, 1:02 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15662/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 1:02 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-243 and MESOS-820
> https://issues.apache.org/jira/browse/MESOS-243
> https://issues.apache.org/jira/browse/MESOS-820
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> It turns out the fix in MESOS-243 was not quite enough to ensure the outstanding status updates are flushed prior to exiting. This is because the call to ProcessBase::send is asynchronous.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 2e53bb80d51bd6d83e4a44a09df0978fb2416dea
>
> Diff: https://reviews.apache.org/r/15662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>