You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/19 01:36:57 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4015: Complete projection assertion

terrymanu opened a new pull request #4015: Complete projection assertion
URL: https://github.com/apache/incubator-shardingsphere/pull/4015
 
 
   For #3947.
   
   Changes proposed in this pull request:
   - Complete generic projection assertion.
   - Complete shorthand projection assertion.
   - Complete column projection assertion.
   - Complete aggregation projection assertion.
   - Complete aggregation distinct projection assertion.
   - Complete expr projection assertion.
   - Complete top projection assertion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4015: Complete projection assertion

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4015: Complete projection assertion
URL: https://github.com/apache/incubator-shardingsphere/pull/4015#issuecomment-575958769
 
 
   ## Pull Request Test Coverage Report for [Build 1412](https://coveralls.io/builds/28192451)
   
   * **5** of **7**   **(71.43%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **65.521%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/TopProjectionExtractor.java](https://coveralls.io/builds/28192451/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FTopProjectionExtractor.java#L58) | 0 | 2 | 0.0%
   <!-- | **Total:** | **5** | **7** | **71.43%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28192451/badge)](https://coveralls.io/builds/28192451) |
   | :-- | --: |
   | Change from base [Build 701](https://coveralls.io/builds/28187027): |  0.0% |
   | Covered Lines: | 10813 |
   | Relevant Lines: | 16503 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] dongzl merged pull request #4015: Complete projection assertion

Posted by GitBox <gi...@apache.org>.
dongzl merged pull request #4015: Complete projection assertion
URL: https://github.com/apache/incubator-shardingsphere/pull/4015
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services