You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/04/05 11:58:03 UTC
Review Request 45736: "Wrong metrics path " exceptions for JMX metrics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45736/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-15708
https://issues.apache.org/jira/browse/AMBARI-15708
Repository: ambari
Description
-------
AmbariMetaInfo adds aggregated functions for jmx metrics, but should add only for ams metrics
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c243552
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 21ad99b
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java 1ccd527
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 2730463
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java cc4bd54
Diff: https://reviews.apache.org/r/45736/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 45736: "Wrong metrics path " exceptions for JMX
metrics
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45736/#review127076
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Квітень 5, 2016, 9:58 до полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45736/
> -----------------------------------------------------------
>
> (Updated Квітень 5, 2016, 9:58 до полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15708
> https://issues.apache.org/jira/browse/AMBARI-15708
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AmbariMetaInfo adds aggregated functions for jmx metrics, but should add only for ams metrics
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c243552
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 21ad99b
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java 1ccd527
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 2730463
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java cc4bd54
>
> Diff: https://reviews.apache.org/r/45736/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 45736: "Wrong metrics path " exceptions for JMX
metrics
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45736/
-----------------------------------------------------------
(Updated Апрель 5, 2016, 10:06 д.п.)
Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-15708
https://issues.apache.org/jira/browse/AMBARI-15708
Repository: ambari
Description
-------
AmbariMetaInfo adds aggregated functions for jmx metrics, but should add only for ams metrics
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c243552
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 21ad99b
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java 1ccd527
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 2730463
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java cc4bd54
Diff: https://reviews.apache.org/r/45736/diff/
Testing
-------
Unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 45736: "Wrong metrics path " exceptions for JMX
metrics
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45736/#review127077
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On April 5, 2016, 9:58 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45736/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:58 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-15708
> https://issues.apache.org/jira/browse/AMBARI-15708
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AmbariMetaInfo adds aggregated functions for jmx metrics, but should add only for ams metrics
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java c243552
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AggregateDefinitionMapping.java 21ad99b
> ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java 1ccd527
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 2730463
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java cc4bd54
>
> Diff: https://reviews.apache.org/r/45736/diff/
>
>
> Testing
> -------
>
> Unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>