You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2006/11/27 19:39:21 UTC

[jira] Created: (LUCENE-729) non-recursive MultiTermDocs

non-recursive MultiTermDocs
---------------------------

                 Key: LUCENE-729
                 URL: http://issues.apache.org/jira/browse/LUCENE-729
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Index
    Affects Versions: 2.0.0
            Reporter: Yonik Seeley
         Assigned To: Yonik Seeley


A non-recursive implementation of MultiTermDocs.next() and skipTo() would be nice as it's currently possible to get a stack overflow in very rare situations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-729) non-recursive MultiTermDocs

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LUCENE-729?page=all ]

Yonik Seeley updated LUCENE-729:
--------------------------------

    Attachment: MultiTermDocs.patch

Attaching non-recursive version.
Seems simple enough, but I'll wait till tomorrow to commit as I'm home sick today with a fever, and I tend to make far more mistakes :-)

> non-recursive MultiTermDocs
> ---------------------------
>
>                 Key: LUCENE-729
>                 URL: http://issues.apache.org/jira/browse/LUCENE-729
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.0.0
>            Reporter: Yonik Seeley
>         Assigned To: Yonik Seeley
>         Attachments: MultiTermDocs.patch
>
>
> A non-recursive implementation of MultiTermDocs.next() and skipTo() would be nice as it's currently possible to get a stack overflow in very rare situations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-729) non-recursive MultiTermDocs

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LUCENE-729?page=all ]

Yonik Seeley resolved LUCENE-729.
---------------------------------

    Resolution: Fixed

Committed.
Thanks for the review Michael, off the top of my head, I don't know of other recursive functions like this.

> non-recursive MultiTermDocs
> ---------------------------
>
>                 Key: LUCENE-729
>                 URL: http://issues.apache.org/jira/browse/LUCENE-729
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.0.0
>            Reporter: Yonik Seeley
>         Assigned To: Yonik Seeley
>         Attachments: MultiTermDocs.patch
>
>
> A non-recursive implementation of MultiTermDocs.next() and skipTo() would be nice as it's currently possible to get a stack overflow in very rare situations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-729) non-recursive MultiTermDocs

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/LUCENE-729?page=comments#action_12453704 ] 
            
Michael McCandless commented on LUCENE-729:
-------------------------------------------

This patch looks good to me.  Do we know if there are any other places where we consume one stack frame per segment?

> non-recursive MultiTermDocs
> ---------------------------
>
>                 Key: LUCENE-729
>                 URL: http://issues.apache.org/jira/browse/LUCENE-729
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 2.0.0
>            Reporter: Yonik Seeley
>         Assigned To: Yonik Seeley
>         Attachments: MultiTermDocs.patch
>
>
> A non-recursive implementation of MultiTermDocs.next() and skipTo() would be nice as it's currently possible to get a stack overflow in very rare situations.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org