You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/12 07:18:14 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7271: [WIP]fix: Fix MultiScopesAnalysisListener#setPublicAttrs log warn frequently

wu-sheng commented on a change in pull request #7271:
URL: https://github.com/apache/skywalking/pull/7271#discussion_r687451383



##########
File path: test/plugin/scenarios/gateway-2.0.x-scenario/config/expectedData.yaml
##########
@@ -57,7 +57,7 @@ segmentItems:
       tags:
       - {key: url, value: 'http://localhost:8080/provider/b/testcase'}
       - {key: http.method, value: GET}
-      - {key: status_code, value: '200'}
+      - {key: http.status_code, value: '200'}

Review comment:
       FYI @JaredTan95 After this change, Resin plugins in https://github.com/SkyAPM/java-plugin-extensions should break. We need a fix after 8.8.0 release, and release 3.0.0. Could you create an issue there to track this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org