You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org> on 2016/06/21 23:16:00 UTC
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Taras Bobrovytsky has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3430
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
IMPALA-3753: Disable create table test for old aggs and joins
The "IMPALA-3530: Clean up test_ddl.py. Part 1." commit made it so that
a query referencing nested types is run as part of the create table
test. This commit temporarily disables the entire create table test for
the OldAggsJoins build in order to make it pass.
Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
---
M tests/common/skip.py
M tests/metadata/test_ddl.py
2 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/30/3430/1
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
PS1, Line 198: # TODO: There is a query in QueryTest/create-table that references nested types, which
: # forces us to skip the entire test case if old aggs and joins are enabled. This needs
: # to be fixed.
> If that's the case, please remove the TODO and replace it with a justificat
I agree that we don't get any additional coverage by running the DDL test with old aggs and joins. I'll add a justification.
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/2//COMMIT_MSG
Commit Message:
PS2, Line 9: The "IMPALA-3530: Clean up test_ddl.py. Part 1." commit made it so that
Maybe reference the offending commit's hash?
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
PS1, Line 198: # TODO: There is a query in QueryTest/create-table that references nested types, which
: # forces us to skip the entire test case if old aggs and joins are enabled. This needs
: # to be fixed.
> Sure, as long as there are no CTAS there seems good.
Looks like there are not. That's fine with me then.
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
PS1, Line 198: # TODO: There is a query in QueryTest/create-table that references nested types, which
: # forces us to skip the entire test case if old aggs and joins are enabled. This needs
: # to be fixed.
Can you pull out the affected tests into a separate file, e.g. nested-types-create-table.test and run that separately, and just put the @Skip on that test?
That's what we do for a number of other similar cases. See other nested-types specific test files:
testdata/workloads/functional-query/queries/QueryTest/nested-types-*
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 3:
All tests passed in this private build: http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/3495/
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has submitted this change and it was merged.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
IMPALA-3753: Disable create table test for old aggs and joins
The "IMPALA-3530: Clean up test_ddl.py. Part 1." (7ed744e) commit made
it so that a query referencing nested types is run as part of the create
table test, which caused the OldAggsJoins build to fail. This commit
disables the create table test for the OldAggsJoins build since it does
not provide any meaningful coverage anyways.
Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Reviewed-on: http://gerrit.cloudera.org:8080/3430
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Taras Bobrovytsky <tb...@cloudera.com>
---
M tests/common/skip.py
M tests/metadata/test_ddl.py
2 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Taras Bobrovytsky: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
PS1, Line 198: # TODO: There is a query in QueryTest/create-table that references nested types, which
: # forces us to skip the entire test case if old aggs and joins are enabled. This needs
: # to be fixed.
> Looks like there are not. That's fine with me then.
If that's the case, please remove the TODO and replace it with a justification for the skip.
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3430
to look at the new patch set (#3).
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
IMPALA-3753: Disable create table test for old aggs and joins
The "IMPALA-3530: Clean up test_ddl.py. Part 1." (7ed744e) commit made
it so that a query referencing nested types is run as part of the create
table test, which caused the OldAggsJoins build to fail. This commit
disables the create table test for the OldAggsJoins build since it does
not provide any meaningful coverage anyways.
Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
---
M tests/common/skip.py
M tests/metadata/test_ddl.py
2 files changed, 12 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/30/3430/3
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 3: Code-Review+2
Forwarding the +2.
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
PS1, Line 198: # TODO: There is a query in QueryTest/create-table that references nested types, which
: # forces us to skip the entire test case if old aggs and joins are enabled. This needs
: # to be fixed.
> Can you pull out the affected tests into a separate file, e.g. nested-types
I think it might be ok to skip this particular test. I'm not sure if we get meaningful additional coverage by running a DDL test under the old aggs and joins.
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:
PS1, Line 198: # TODO: There is a query in QueryTest/create-table that references nested types, which
: # forces us to skip the entire test case if old aggs and joins are enabled. This needs
: # to be fixed.
> I think it might be ok to skip this particular test. I'm not sure if we get
Sure, as long as there are no CTAS there seems good.
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3753: Disable create table test for old aggs and joins
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3430
to look at the new patch set (#2).
Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................
IMPALA-3753: Disable create table test for old aggs and joins
The "IMPALA-3530: Clean up test_ddl.py. Part 1." commit made it so that
a query referencing nested types is run as part of the create table
test, which caused the OldAggsJoins build to fail. This commit disables
the create table test for the OldAggsJoins build since it does not
provide any meaningful coverage anyways.
Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
---
M tests/common/skip.py
M tests/metadata/test_ddl.py
2 files changed, 12 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/30/3430/2
--
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>