You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/24 04:26:40 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong opened a new pull request #4545: [Fix-4544][UI] process-instance delete button display condition error

zhuangchong opened a new pull request #4545:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4545


   ## What is the purpose of the pull request
   this PR closes #4544 
   
   fix process-instance delete button display condition,When the status is success or failure or stop or pause, the page displays the delete button.
   
   ## Brief change log
   update delete button disabled value in the instance/pages/list/_source/list.vue
   
   ## Verify this pull request
   This change added tests and can be verified as follows:
     - *Manually verified the change by testing locally.*


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] xingchun-chen merged pull request #4545: [Fix-4544][UI] process-instance delete button display condition error

Posted by GitBox <gi...@apache.org>.
xingchun-chen merged pull request #4545:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] xingchun-chen merged pull request #4545: [Fix-4544][UI] process-instance delete button display condition error

Posted by GitBox <gi...@apache.org>.
xingchun-chen merged pull request #4545:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4545: [Fix-4544][UI] process-instance delete button display condition error

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4545:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4545#issuecomment-766290541


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=VULNERABILITY)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=SECURITY_HOTSPOT)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4545&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4545&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4545&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4545&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4545: [Fix-4544][UI] process-instance delete button display condition error

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4545:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4545#issuecomment-766290213


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=h1) Report
   > Merging [#4545](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=desc) (0e668d1) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/17c06ce966fc5c6a6136ee142e4698312fe6532f?el=desc) (17c06ce) will **increase** coverage by `1.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #4545      +/-   ##
   ============================================
   + Coverage     43.60%   44.72%   +1.11%     
   - Complexity     3201     3335     +134     
   ============================================
     Files           471      527      +56     
     Lines         21748    22815    +1067     
     Branches       2638     2667      +29     
   ============================================
   + Hits           9484    10204     +720     
   - Misses        11362    11689     +327     
   - Partials        902      922      +20     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../server/worker/processor/TaskExecuteProcessor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9wcm9jZXNzb3IvVGFza0V4ZWN1dGVQcm9jZXNzb3IuamF2YQ==) | `62.66% <0.00%> (-6.46%)` | `7.00% <0.00%> (ø%)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...dolphinscheduler/dao/entity/ProcessDefinition.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzRGVmaW5pdGlvbi5qYXZh) | `76.54% <0.00%> (-4.41%)` | `40.00% <0.00%> (-4.00%)` | |
   | [...scheduler/dao/entity/ProcessDefinitionVersion.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9jZXNzRGVmaW5pdGlvblZlcnNpb24uamF2YQ==) | `44.15% <0.00%> (-4.04%)` | `23.00% <0.00%> (-4.00%)` | |
   | [...olphinscheduler/dao/datasource/HiveDataSource.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvSGl2ZURhdGFTb3VyY2UuamF2YQ==) | `80.00% <0.00%> (-1.82%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...inscheduler/server/worker/config/WorkerConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9jb25maWcvV29ya2VyQ29uZmlnLmphdmE=) | `13.33% <0.00%> (-1.49%)` | `4.00% <0.00%> (ø%)` | |
   | [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `59.72% <0.00%> (-1.39%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `52.08% <0.00%> (-0.70%)` | `10.00% <0.00%> (-1.00%)` | |
   | [...er/api/controller/ProcessDefinitionController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0RlZmluaXRpb25Db250cm9sbGVyLmphdmE=) | `71.84% <0.00%> (-0.28%)` | `20.00% <0.00%> (ø%)` | |
   | [...scheduler/api/controller/AlertGroupController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQWxlcnRHcm91cENvbnRyb2xsZXIuamF2YQ==) | `5.00% <0.00%> (-0.27%)` | `2.00% <0.00%> (ø%)` | |
   | ... and [132 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=footer). Last update [17c06ce...0e668d1](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org