You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by ki...@apache.org on 2021/07/19 08:32:30 UTC

[dolphinscheduler] 01/01: [1.3.7-prepare#5776][Improvement][Worker] Improve task process status log

This is an automated email from the ASF dual-hosted git repository.

kirs pushed a commit to branch 1.3.7-#prepare-#5776
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git

commit d22f00e2270ef6f91b262d0347f00df8cf06437d
Author: CalvinKirs <ki...@apache.org>
AuthorDate: Mon Jul 19 16:32:12 2021 +0800

    [1.3.7-prepare#5776][Improvement][Worker] Improve task process status log
    
    Issue #5741
    Pr #5776
---
 .../server/worker/task/AbstractCommandExecutor.java               | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java
index 4baf8af..377d2c8 100644
--- a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java
+++ b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java
@@ -213,12 +213,6 @@ public abstract class AbstractCommandExecutor {
         // waiting for the run to finish
         boolean status = process.waitFor(remainTime, TimeUnit.SECONDS);
 
-
-        logger.info("process has exited, execute path:{}, processId:{} ,exitStatusCode:{}",
-                taskExecutionContext.getExecutePath(),
-                processId
-                , result.getExitStatusCode());
-
         // if SHELL task exit
         if (status) {
             // set appIds
@@ -238,6 +232,8 @@ public abstract class AbstractCommandExecutor {
             result.setExitStatusCode(EXIT_CODE_FAILURE);
         }
 
+        logger.info("process has exited, execute path:{}, processId:{} ,exitStatusCode:{} ,processWaitForStatus:{} ,processExitValue:{}",
+            taskExecutionContext.getExecutePath(), processId, result.getExitStatusCode(), status, process.exitValue());
 
         return result;
     }