You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/10/27 22:57:28 UTC
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/275
Fix various integration tests + code tidies
Note that the commit "DynamicCluster: ensure cause of resize error is reported" will clash with https://github.com/apache/incubator-brooklyn/pull/272 from @ahgittin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/various-20141024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit ee9b0fb9a129bf5273f561d9dfd0fdd91ebc054b
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T13:40:13Z
Fix EntityExecutionManagerTest
- Failed in jenkins with “wrong” tasks being GC’ed.
- Aled speculates the two tasks terminated in the same millisecond,
so introduce small delay between tasks and also log more info about
tasks on error.
commit 026379252a61c2b6839557aab06705a6ca62cf4e
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:03:02Z
DynamicCluster: ensure cause of resize error is reported
commit ac9c691f8fed97e7f7760bb463abd51ab9d89d35
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:08:11Z
Add TestApplication.newSimulatedLocation()
commit 53ac2cdeaee10d396ac47501cf961f5d0c3b66cd
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:08:23Z
Bump TomcatServer version to 5.0.56
commit 1038d52619af564b2e164691569dcc8eec6c5184
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:09:16Z
TestJavaWebAppEntity: convert to interface+impl
commit 8764a9491c1eeed870b68cbac8ae0e1e1077ca65
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T20:42:43Z
TomcatAutoScalerPolicyTest: code tidy
commit 6143775a59479263192e121566ee66718c430e01
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T09:46:06Z
Use Duration for AutoScalerPolicy.builder methods
- instead of taking long, take Duration parameter.
- for minPeriodBetweenExecs, resizeUpStabilizationDelay,
resizeDownStabilizationDelay, and maxReachedNotificationDelay.
- Test tidy (for use of deprecated methods)
commit 5ea4b2fd846163592cb5c9f272262066eecfda9f
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T12:21:25Z
Fix Solr version number
- and uploaded solr-4.7.2.tgz to
developers.cloudsoftcorp.com/brooklyn/repository/SolrServer/4.7.2/solr-4.7.2.tgz
commit 0306eb1c431fb5a5bd3de19fb1ae91f46135194f
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T14:37:17Z
Asserts: log.info with details of failure
commit 1edcd9369d5c04f262e781407c46700c25f61bf4
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T14:38:00Z
BrooklynMavenArtifactsTest: allow retry for URL
- have seen response code 500 from repository.apache.org for snapshot
builds, so retry for default timeout (30 seconds)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/275#issuecomment-60775762
Thanks @richardcloudsoft - have incorporated those comments and squashed+rebased. Will merge now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
Posted by aledsage <gi...@git.apache.org>.
GitHub user aledsage reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/275
Fix various integration tests + code tidies
Note that the commit "DynamicCluster: ensure cause of resize error is reported" will clash with https://github.com/apache/incubator-brooklyn/pull/272 from @ahgittin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/various-20141024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 82ed1857b7e66efb40987b83dc8ca133daea366f
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T13:40:13Z
Fix EntityExecutionManagerTest
- Failed in jenkins with “wrong” tasks being GC’ed.
- Aled speculates the two tasks terminated in the same millisecond,
so introduce small delay between tasks and also log more info about
tasks on error.
commit 8b3ea798c486460c8c63437588020680a06061d4
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:03:02Z
DynamicCluster: ensure cause of resize error is reported
commit e4c328644dd6b60cdbcfc2d4a0dc4baa1fec00e8
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:08:11Z
Add TestApplication.newSimulatedLocation()
commit fdb31d7fc5d73ecd44a14a6a21d8f38f32f85353
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:08:23Z
Bump TomcatServer version to 5.0.56
commit 2c72b0a1795ade03b63439519a7d2f08bdbf551e
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T16:09:16Z
TestJavaWebAppEntity: tidies
commit 51a4fe5b9418d8da098c638584951be5a6b300c5
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-24T20:42:43Z
TomcatAutoScalerPolicyTest: code tidy
commit 18536d1380f85f1ac41b24f480afb275af066321
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T09:46:06Z
Use Duration for AutoScalerPolicy.builder methods
- instead of taking long, take Duration parameter.
- for minPeriodBetweenExecs, resizeUpStabilizationDelay,
resizeDownStabilizationDelay, and maxReachedNotificationDelay.
- Test tidy (for use of deprecated methods)
commit 43ca4d5c206bb7d68b34a2a1756c09881e969191
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T12:21:25Z
Fix Solr version number
- and uploaded solr-4.7.2.tgz to
developers.cloudsoftcorp.com/brooklyn/repository/SolrServer/4.7.2/solr-4.7.2.tgz
commit 5dae435e7f143d98762796604f7deb5c3035b530
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T14:37:17Z
Asserts: log.info with details of failure
commit 766b7aada5cd080f3c6f5be6fec9daf4590dfb8e
Author: Aled Sage <al...@gmail.com>
Date: 2014-10-27T14:38:00Z
BrooklynMavenArtifactsTest: allow retry for URL
- have seen response code 500 from repository.apache.org for snapshot
builds, so retry for default timeout (30 seconds)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/275#issuecomment-60760317
Looks good. A couple of minor comments, and we need to wait for the PR builder to tell success. After that, ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/275#issuecomment-60758801
Closing and re-opening to kick off the build again. First failure was due to merge conflicts; second was an abort caused by `IllegalStateException: Unable to call isArchivingDisabled. Invalid object ID 28`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix various integration tests + c...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---