You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:29:36 UTC

[GitHub] [nifi] joewitt commented on pull request #4169: NIFI-7338 Adding GetSmbFile and PutSmbFile processors #2

joewitt commented on pull request #4169:
URL: https://github.com/apache/nifi/pull/4169#issuecomment-669963201


   @si-sun the thread safety point is still of interest.  That we are synchronizing initialization is good.  But is the class itself thread safe for concurrent usage?  I've just looked briefly on their code/javadocs and not seeing any indicator yet.  We should know this and if it is safe then great.   If it is not then we need to make the class TriggerSerially so that it wont allow multiple threads.
   
   Also, the windows and osx tests failed on the last build.  I suspect the osx issue is just environment issues on github ci that we see time to time.  But the windows builds have been quite stable.  Have you built this on windows?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org