You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/12 14:12:00 UTC

[jira] [Commented] (AIRFLOW-4296) Remove py2 in ci process

    [ https://issues.apache.org/jira/browse/AIRFLOW-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816296#comment-16816296 ] 

ASF GitHub Bot commented on AIRFLOW-4296:
-----------------------------------------

zhongjiajie commented on pull request #5090: [AIRFLOW-4296][AIP-3-subtask-18] Remove py2 in ci process
URL: https://github.com/apache/airflow/pull/5090
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4296
   
   ### Description
   
   My PR https://github.com/apache/airflow/pull/5020 CI failed, and the sample log https://api.travis-ci.org/v3/job/519213992/log.txt
   
   ```sh
   Traceback (most recent call last):
     File "/usr/local/bin/airflow", line 21, in <module>
       from airflow import configuration
     File "/usr/local/lib/python2.7/dist-packages/airflow/__init__.py", line 36, in <module>
       from airflow import settings, configuration as conf
     File "/usr/local/lib/python2.7/dist-packages/airflow/settings.py", line 32, in <module>
       from airflow.utils.sqlalchemy import setup_event_handlers
     File "/usr/local/lib/python2.7/dist-packages/airflow/utils/sqlalchemy.py", line 22, in <module>
       import json
     File "/usr/local/lib/python2.7/dist-packages/airflow/utils/json.py", line 27, in <module>
       class AirflowJsonEncoder(json.JSONEncoder):
   AttributeError: 'module' object has no attribute 'JSONEncoder'
   ```
   
   And I found out we ci process still have py2, So remove `from __future__ import absolute_import` will cause error. This PR are try to fix this.
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove py2 in ci process 
> -------------------------
>
>                 Key: AIRFLOW-4296
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4296
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: ci
>    Affects Versions: 1.10.2
>            Reporter: zhongjiajie
>            Assignee: zhongjiajie
>            Priority: Major
>              Labels: patch
>
> We still have py2 in our CI process, and this will cause error when in AIP-3 PR, we should remove that



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)