[GitHub] spark pull request #21849: [SPARK-24243][CORE] Expose exceptions from InProc...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21849#discussion_r216058203
  
    --- Diff: launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
    @@ -46,6 +47,25 @@ public synchronized void disconnect() {
         }
       }
     
    +  /**
    +   * Parses the logs of {@code spark-submit} and returns the last exception thrown.
    +   *
    +   * <p>
    +   *   Since {@link SparkLauncher} runs {@code spark-submit} in a sub-process, its difficult to
    --- End diff --
    
    it's
    
    also, small nit: keep the text at the same indent level as the p tags (as is done in other classes).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org