You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/19 08:44:58 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #2258: Ref gitlab conn id mr commit
warren830 opened a new pull request, #2258:
URL: https://github.com/apache/incubator-devlake/pull/2258
# Summary
add conn id and e2e to mr commits
### Does this close any open issues?
Please mention the issues here.
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2258: Ref gitlab conn id mr commit-4
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2258:
URL: https://github.com/apache/incubator-devlake/pull/2258#discussion_r901282110
##########
plugins/gitlab/e2e/mr_commits_test.go:
##########
@@ -39,19 +39,64 @@ func TestGitlabCommitDataFlow(t *testing.T) {
ProjectId: 20171709,
},
}
+
+ // Prepare _tool_gitlab_pull_requests for mr_commit convertor test
+ err := dataflowTester.Db.Migrator().DropTable("_raw_gitlab_api_merge_requests")
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #2258: Ref gitlab conn id mr commit-4
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #2258:
URL: https://github.com/apache/incubator-devlake/pull/2258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2258: Ref gitlab conn id mr commit-4
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #2258:
URL: https://github.com/apache/incubator-devlake/pull/2258#discussion_r901250087
##########
plugins/gitlab/e2e/snapshot_tables/commits.csv:
##########
@@ -1,64 +1 @@
sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark,additions,deletions,dev_eq,message,author_name,author_email,authored_date,author_id,committer_name,committer_email,committed_date,committer_id
-03b566ec2af3106808f385dacdbd3edf54f4c2c4,"{""ConnectionId"":1,""ProjectId"":20171709}",_raw_gitlab_api_commit,3,,7,1,0,"update README.md
Review Comment:
Is empty csv right? There are some commits in _tool_gitlab_commits.csv
##########
plugins/gitlab/e2e/mr_commits_test.go:
##########
@@ -39,19 +39,64 @@ func TestGitlabCommitDataFlow(t *testing.T) {
ProjectId: 20171709,
},
}
+
+ // Prepare _tool_gitlab_pull_requests for mr_commit convertor test
+ err := dataflowTester.Db.Migrator().DropTable("_raw_gitlab_api_merge_requests")
Review Comment:
it's not necessary. Because `ImportCsvIntoRawTable` dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org