You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/25 09:04:41 UTC

[GitHub] [flink] StephanEwen commented on pull request #13034: [FLINK-9992][tests] Fix FsStorageLocationReferenceTest#testEncodeAndDecode by adding retries to generate a valid path

StephanEwen commented on pull request #13034:
URL: https://github.com/apache/flink/pull/13034#issuecomment-679901944


   Thanks for fixing this instability.
   
   Some comments from my side:
     - It would be nice to have non-alphanumeric characters.
     - The retries are okay, but we could also have a list of forbidden chars (like underscore, colon, whitespace) that we avoid in the random string generation.
     - If you want to stick with re-tries, I would suggest to make it a while loop until you have a valid string. The number 5 for retries seems very arbitrary.
   
   Other note: The test is missing the ':' between host and port, so it never has a port but counts the number into the hostname.
   Would be nice to fix that as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org