You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/04/04 11:44:53 UTC

[GitHub] [beam] AnandInguva opened a new pull request, #26099: Python 3.11 support with cloudpickle as default

AnandInguva opened a new pull request, #26099:
URL: https://github.com/apache/beam/pull/26099

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26099:
URL: https://github.com/apache/beam/pull/26099#discussion_r1157348236


##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -78,14 +78,16 @@
 
 # pylint: disable=wrong-import-order, wrong-import-position
 # Avoid dependencies on the full SDK.
-try:
-  # Import dill from the pickler module to make sure our monkey-patching of dill
-  # occurs.
-  from apache_beam.internal.dill_pickler import dill
-except ImportError:
-  # We fall back to using the stock dill library in tests that don't use the
-  # full Python SDK.
-  import dill
+

Review Comment:
   Let's try to keep this file as is and include dill as a test dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva closed pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva closed pull request #26099: Python 3.11 support with cloudpickle as default
URL: https://github.com/apache/beam/pull/26099


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26099:
URL: https://github.com/apache/beam/pull/26099#discussion_r1157345911


##########
sdks/python/apache_beam/coders/coder_impl.py:
##########
@@ -73,6 +73,11 @@
 except ImportError:
   dataclasses = None  # type: ignore
 
+if sys.version_info < (3, 11):

Review Comment:
   let's use user-specified pickler like in other places. the ux should allow user to override the default pickler in once place at start time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26099:
URL: https://github.com/apache/beam/pull/26099#discussion_r1157352534


##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -78,14 +78,16 @@
 
 # pylint: disable=wrong-import-order, wrong-import-position
 # Avoid dependencies on the full SDK.
-try:
-  # Import dill from the pickler module to make sure our monkey-patching of dill
-  # occurs.
-  from apache_beam.internal.dill_pickler import dill
-except ImportError:
-  # We fall back to using the stock dill library in tests that don't use the
-  # full Python SDK.
-  import dill
+

Review Comment:
   But this file uses a method called `maybe_dill_dumps` which uses dill. Would that create an issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on code in PR #26099:
URL: https://github.com/apache/beam/pull/26099#discussion_r1157349195


##########
sdks/python/apache_beam/coders/coder_impl.py:
##########
@@ -73,6 +73,11 @@
 except ImportError:
   dataclasses = None  # type: ignore
 
+if sys.version_info < (3, 11):

Review Comment:
   Yes. True. My goal here is to see what tests fail and how to resolve the first.
   
   Once they are resolved, I will takle on adding dill as an optional dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26099:
URL: https://github.com/apache/beam/pull/26099#issuecomment-1496491056

   Run Python_Runners PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #26099:
URL: https://github.com/apache/beam/pull/26099#discussion_r1157342409


##########
sdks/python/apache_beam/typehints/schemas_test.py:
##########
@@ -49,6 +48,11 @@
 from apache_beam.typehints.testing.strategies import named_fields
 from apache_beam.utils.timestamp import Timestamp
 
+try:
+  import dill

Review Comment:
   we can include dill as a [test] dependency, and use new version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #26099: Python 3.11 support with cloudpickle as default

Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #26099:
URL: https://github.com/apache/beam/pull/26099#issuecomment-1496229416

   4 tests I see in GitHub actions
   ```
   FAILED apache_beam/runners/direct/direct_runner_test.py::DirectRunnerRetryTests::test_retry_fork_graph
   FAILED apache_beam/transforms/combinefn_lifecycle_test.py::LocalCombineFnLifecycleTest_0::test_combine
   FAILED apache_beam/transforms/combinefn_lifecycle_test.py::LocalCombineFnLifecycleTest_1::test_combine
   FAILED apache_beam/transforms/create_test.py::CreateTest::test_create_uses_coder_for_pickling
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org