You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/30 04:24:36 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19706: Move closeFederationExecutor into DatabaseCommunicationEngine
codecov-commenter commented on PR #19706:
URL: https://github.com/apache/shardingsphere/pull/19706#issuecomment-1200085647
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19706?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19706](https://codecov.io/gh/apache/shardingsphere/pull/19706?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eda6458) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2ac65b3088460ac939704d4b551df6b5d2c0198b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ac65b3) will **increase** coverage by `0.07%`.
> The diff coverage is `87.50%`.
```diff
@@ Coverage Diff @@
## master #19706 +/- ##
============================================
+ Coverage 60.00% 60.07% +0.07%
- Complexity 2388 2389 +1
============================================
Files 3846 3846
Lines 54813 54812 -1
Branches 7659 7658 -1
============================================
+ Hits 32888 32927 +39
+ Misses 19104 19060 -44
- Partials 2821 2825 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19706?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ication/jdbc/connection/JDBCBackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/19706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvY29ubmVjdGlvbi9KREJDQmFja2VuZENvbm5lY3Rpb24uamF2YQ==) | `81.37% <ø> (+2.99%)` | :arrow_up: |
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/19706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `84.04% <87.50%> (+32.87%)` | :arrow_up: |
| [...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/19706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `27.27% <0.00%> (ø)` | |
| [...c/executor/callback/ProxyJDBCExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/19706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0b3IvY2FsbGJhY2svUHJveHlKREJDRXhlY3V0b3JDYWxsYmFjay5qYXZh) | `15.62% <0.00%> (+15.62%)` | :arrow_up: |
| [...tor/callback/ProxyJDBCExecutorCallbackFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0b3IvY2FsbGJhY2svUHJveHlKREJDRXhlY3V0b3JDYWxsYmFja0ZhY3RvcnkuamF2YQ==) | `20.00% <0.00%> (+20.00%)` | :arrow_up: |
| [...k/impl/ProxyPreparedStatementExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/19706/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0b3IvY2FsbGJhY2svaW1wbC9Qcm94eVByZXBhcmVkU3RhdGVtZW50RXhlY3V0b3JDYWxsYmFjay5qYXZh) | `66.66% <0.00%> (+66.66%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org