You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/12 14:46:16 UTC

[GitHub] [airflow] phanikumv opened a new pull request, #26345: Add DataFlow operations to Azure DataFactory hook

phanikumv opened a new pull request, #26345:
URL: https://github.com/apache/airflow/pull/26345

   This PR adds the functionality to perform DataFlow operations using Azure DataFactory hook
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r971030906


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str,
+        factory_name: str,

Review Comment:
   @josh-fell - changing the type defn's to `Optional` in other methods without changing in `_dataflow_exists()` leads to below errors
   
   ```
   Run mypy for providers.................................................................Failed
   - hook id: run-mypy
   - exit code: 1
   
   airflow/providers/microsoft/azure/hooks/data_factory.py:545: error: Argument 2
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
                   resource_group_name,
                   ^
   airflow/providers/microsoft/azure/hooks/data_factory.py:546: error: Argument 3
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
                   factory_name,
                   ^
   airflow/providers/microsoft/azure/hooks/data_factory.py:574: error: Argument 2
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
               if self._dataflow_exists(dataflow_name, resource_group_name, f...
                                                       ^
   airflow/providers/microsoft/azure/hooks/data_factory.py:574: error: Argument 3
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
       ...lf._dataflow_exists(dataflow_name, resource_group_name, factory_name):
                                                                  ^
   Found 4 errors in 1 file (checked 1 source file)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] josh-fell commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970923842


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str,
+        factory_name: str,

Review Comment:
   These, and in other "public" methods, should still be Optional params, but in `_dataflow_exists()` they should be required right?. Users should still be able to call `get_dataflow()`, `update_dataflow()`, create_dataflow()`, and `delete_dataflow()` without having to specify the `resource_group_name` and `factory_name`.
   
   My fault for not being clearer.



##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str,
+        factory_name: str,

Review Comment:
   These, and in other "public" methods, should still be Optional params, but in `_dataflow_exists()` they should be required right?. Users should still be able to call `get_dataflow()`, `update_dataflow()`, `create_dataflow()`, and `delete_dataflow()` without having to specify the `resource_group_name` and `factory_name`.
   
   My fault for not being clearer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970927122


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str,
+        factory_name: str,

Review Comment:
   Not a problem, will change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r971030906


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str,
+        factory_name: str,

Review Comment:
   @josh-fell - changing the type defn's to `Optional` in other methods without changing in _dataflow_exists() leads to below errors
   
   ```
   Run mypy for providers.................................................................Failed
   - hook id: run-mypy
   - exit code: 1
   
   airflow/providers/microsoft/azure/hooks/data_factory.py:545: error: Argument 2
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
                   resource_group_name,
                   ^
   airflow/providers/microsoft/azure/hooks/data_factory.py:546: error: Argument 3
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
                   factory_name,
                   ^
   airflow/providers/microsoft/azure/hooks/data_factory.py:574: error: Argument 2
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
               if self._dataflow_exists(dataflow_name, resource_group_name, f...
                                                       ^
   airflow/providers/microsoft/azure/hooks/data_factory.py:574: error: Argument 3
   to "_dataflow_exists" of "AzureDataFactoryHook" has incompatible type
   "Optional[str]"; expected "str"  [arg-type]
       ...lf._dataflow_exists(dataflow_name, resource_group_name, factory_name):
                                                                  ^
   Found 4 errors in 1 file (checked 1 source file)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970849711


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -477,12 +479,112 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: Optional[str] = None,
+        factory_name: Optional[str] = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(self, resource_group_name, factory_name, dataflow_name) -> bool:

Review Comment:
   Done with the type annotation in latest commit , resource_group_name & factory_name can be passed by the below lines if not passed.
   ```
   
           bind_argument("resource_group_name", "extra__azure_data_factory__resource_group_name")
           bind_argument("factory_name", "extra__azure_data_factory__factory_name")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] josh-fell commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970848442


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,

Review Comment:
   Cool, on the same page. Let's make these required params then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970927122


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str,
+        factory_name: str,

Review Comment:
   Not a problem, will change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970849711


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -477,12 +479,112 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: Optional[str] = None,
+        factory_name: Optional[str] = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(self, resource_group_name, factory_name, dataflow_name) -> bool:

Review Comment:
   Done with the change in latest commit , resource_group_name & factory_name can be passed by the below lines if not passed.
   ```
   
           bind_argument("resource_group_name", "extra__azure_data_factory__resource_group_name")
           bind_argument("factory_name", "extra__azure_data_factory__factory_name")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970846683


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,

Review Comment:
   yeah they can be passed from the decorator already



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] pankajkoti commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
pankajkoti commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r969260540


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -477,12 +479,112 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: Optional[str] = None,
+        factory_name: Optional[str] = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(self, resource_group_name, factory_name, dataflow_name) -> bool:

Review Comment:
   Can we type annotate the arguments here? Also, since `resource_group_name` & `factory_name` could be `None`, does the `list_by_factory` method work well? Or do we need to handle the case separately for `None` values? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] josh-fell commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
josh-fell commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970243635


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -477,12 +479,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.

Review Comment:
   Nice catch!



##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,

Review Comment:
   Would these ever actually be `None`? I assume the methods calling this one would have had the `resource_group_name` and `factory_name` applied already (if not provided explicitly prior).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] phanikumv commented on a diff in pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #26345:
URL: https://github.com/apache/airflow/pull/26345#discussion_r970919886


##########
airflow/providers/microsoft/azure/hooks/data_factory.py:
##########
@@ -479,12 +481,121 @@ def delete_dataset(
         Delete the dataset.
 
         :param dataset_name: The dataset name.
-        :param resource_group_name: The dataset name.
+        :param resource_group_name: The resource group name.
         :param factory_name: The factory name.
         :param config: Extra parameters for the ADF client.
         """
         self.get_conn().datasets.delete(resource_group_name, factory_name, dataset_name, **config)
 
+    @provide_targeted_factory
+    def get_dataflow(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,
+        **config: Any,
+    ) -> DataFlow:
+        """
+        Get the dataflow.
+
+        :param dataflow_name: The dataflow name.
+        :param resource_group_name: The resource group name.
+        :param factory_name: The factory name.
+        :param config: Extra parameters for the ADF client.
+        :return: The dataflow.
+        """
+        return self.get_conn().data_flows.get(resource_group_name, factory_name, dataflow_name, **config)
+
+    def _dataflow_exists(
+        self,
+        dataflow_name: str,
+        resource_group_name: str | None = None,
+        factory_name: str | None = None,

Review Comment:
   made them required params 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #26345: Add DataFlow operations to Azure DataFactory hook

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26345:
URL: https://github.com/apache/airflow/pull/26345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org