[incubator-datasketches-cpp] branch master updated: Issue-165: Remove c-style const casts from kll/ and common directories

[al...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

alsay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new 337fbd7  Issue-165: Remove c-style const casts from kll/ and common directories
     new c67d92f  Merge pull request #166 from gaborkaszab/const_cast
337fbd7 is described below

commit 337fbd74e88f9507c995e66d0a6353f7722bfa0a
Author: Gabor Kaszab <ga...@cloudera.com>
AuthorDate: Wed Jul 22 14:26:13 2020 +0200

    Issue-165: Remove c-style const casts from kll/ and common directories
    
    The motivation behind this change is that I recently started integrating
    DataSketches KLL into Apache Impala and our Clang tidy build showed some issues
    where c-style casts were used to remove const-ness of variables.
---
 common/include/serde.hpp        |  2 +-
 kll/include/kll_sketch_impl.hpp | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common/include/serde.hpp b/common/include/serde.hpp
index 74de784..d0819d8 100644
--- a/common/include/serde.hpp
+++ b/common/include/serde.hpp
@@ -50,7 +50,7 @@ struct serde<T, typename std::enable_if<std::is_arithmetic<T>::value>::type> {
   void serialize(std::ostream& os, const T* items, unsigned num) {
     bool failure = false;
     try {
-      os.write((char*)items, sizeof(T) * num);
+      os.write(reinterpret_cast<const char*>(items), sizeof(T) * num);
     } catch (std::ostream::failure& e) {
       failure = true;
     }
diff --git a/kll/include/kll_sketch_impl.hpp b/kll/include/kll_sketch_impl.hpp
index 15d6ae2..9b6c68e 100644
--- a/kll/include/kll_sketch_impl.hpp
+++ b/kll/include/kll_sketch_impl.hpp
@@ -378,21 +378,21 @@ template<typename T, typename C, typename S, typename A>
 void kll_sketch<T, C, S, A>::serialize(std::ostream& os) const {
   const bool is_single_item = n_ == 1;
   const uint8_t preamble_ints(is_empty() || is_single_item ? PREAMBLE_INTS_SHORT : PREAMBLE_INTS_FULL);
-  os.write((char*)&preamble_ints, sizeof(preamble_ints));
+  os.write(reinterpret_cast<const char*>(&preamble_ints), sizeof(preamble_ints));
   const uint8_t serial_version(is_single_item ? SERIAL_VERSION_2 : SERIAL_VERSION_1);
-  os.write((char*)&serial_version, sizeof(serial_version));
+  os.write(reinterpret_cast<const char*>(&serial_version), sizeof(serial_version));
   const uint8_t family(FAMILY);
-  os.write((char*)&family, sizeof(family));
+  os.write(reinterpret_cast<const char*>(&family), sizeof(family));
   const uint8_t flags_byte(
       (is_empty() ? 1 << flags::IS_EMPTY : 0)
     | (is_level_zero_sorted_ ? 1 << flags::IS_LEVEL_ZERO_SORTED : 0)
     | (is_single_item ? 1 << flags::IS_SINGLE_ITEM : 0)
   );
-  os.write((char*)&flags_byte, sizeof(flags_byte));
+  os.write(reinterpret_cast<const char*>(&flags_byte), sizeof(flags_byte));
   os.write((char*)&k_, sizeof(k_));
   os.write((char*)&m_, sizeof(m_));
   const uint8_t unused(0);
-  os.write((char*)&unused, sizeof(unused));
+  os.write(reinterpret_cast<const char*>(&unused), sizeof(unused));
   if (is_empty()) return;
   if (!is_single_item) {
     os.write((char*)&n_, sizeof(n_));


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org