You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "yangxikun (via GitHub)" <gi...@apache.org> on 2023/02/09 15:21:03 UTC
[GitHub] [apisix] yangxikun opened a new pull request, #8823: feat: opentelemetry plugin config collector.address support specify https scheme
yangxikun opened a new pull request, #8823:
URL: https://github.com/apache/apisix/pull/8823
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes yangxikun/opentelemetry-lua#60
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8823: feat: opentelemetry plugin config collector.address support specify https scheme
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on code in PR #8823:
URL: https://github.com/apache/apisix/pull/8823#discussion_r1103942843
##########
docs/en/latest/plugins/opentelemetry.md:
##########
@@ -58,7 +58,7 @@ You can set up the collector by configuring it in you configuration file (`conf/
| trace_id_source | enum | random | Source of the trace ID. Valid values are `random` or `x-request-id`. When set to `x-request-id`, the value of the `x-request-id` header will be used as trace ID. Make sure that is matches the regex pattern `[0-9a-f]{32}`. |
| resource | object | | Additional [resource](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md) appended to the trace. |
| collector | object | {address = "127.0.0.1:4318", request_timeout = 3} | OpenTelemetry Collector configuration. |
-| collector.address | string | 127.0.0.1:4318 | Collector address. |
+| collector.address | string | 127.0.0.1:4318 | Collector address. If the collector serve on https, use https://127.0.0.1:4318 as address. |
Review Comment:
```suggestion
| collector.address | string | 127.0.0.1:4318 | Collector address. If the collector serves on https, use https://127.0.0.1:4318 as the address. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8823: feat: opentelemetry plugin config collector.address support specify https scheme
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander merged PR #8823:
URL: https://github.com/apache/apisix/pull/8823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] yangxikun commented on pull request #8823: feat: opentelemetry plugin config collector.address support specify https scheme
Posted by "yangxikun (via GitHub)" <gi...@apache.org>.
yangxikun commented on PR #8823:
URL: https://github.com/apache/apisix/pull/8823#issuecomment-1425765323
@spacewander The failed checks seems not relevant with my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #8823: feat: opentelemetry plugin config collector.address support specify https scheme
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on PR #8823:
URL: https://github.com/apache/apisix/pull/8823#issuecomment-1425067050
Please make the CI pass, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org