You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajani Karuturi <ra...@gmail.com> on 2013/10/23 07:26:10 UTC

Review Request 14867: api call to import ldap users to the same domains in cloudstack

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-4866
    https://issues.apache.org/jira/browse/CLOUDSTACK-4866


Repository: cloudstack-git


Description
-------

Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
    
        TODO:
        1. error handling of no domains present, nested hierarchy
        2. handling the case when the api call fails for a specific user/users
        3. test cases for LdapUserManager


Diffs
-----

  api/src/com/cloud/user/DomainService.java 7c302e3 
  client/tomcatconf/commands.properties.in 0296de0 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
  plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
  plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
  server/src/com/cloud/user/DomainManagerImpl.java b885c48 
  server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 

Diff: https://reviews.apache.org/r/14867/diff/


Testing
-------

testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)


Thanks,

Rajani Karuturi

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Ian Duffy <ia...@ianduffy.ie>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27669
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Duffy


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Rajani Karuturi <ra...@gmail.com>.

> On Oct. 23, 2013, 6:22 a.m., Prasanna Santhanam wrote:
> > How is the import behaviour when OUs contain other OUs?

That is still not done. (Its the second part of TODO:1, nested hierarchy)


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Rajani Karuturi <ra...@gmail.com>.

> On Oct. 23, 2013, 6:22 a.m., Prasanna Santhanam wrote:
> > How is the import behaviour when OUs contain other OUs?
> 
> Rajani Karuturi wrote:
>     That is still not done. (Its the second part of TODO:1, nested hierarchy)
> 
> Prasanna Santhanam wrote:
>     Ah, didn't notice the TODO. Is there a spec file on how this is planned to be handled? Right now it seems you will just create domains under ROOT behind-the-scenes?

Nothing yet. I will update the wiki page created by Ian https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+implementation+improvement+and+user+provisioning
Yes, right now it just imports the same hierarchy(1-level) to cloudstack under ROOT with the specified account type. 


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Prasanna Santhanam <ts...@apache.org>.

> On Oct. 23, 2013, 6:22 a.m., Prasanna Santhanam wrote:
> > How is the import behaviour when OUs contain other OUs?
> 
> Rajani Karuturi wrote:
>     That is still not done. (Its the second part of TODO:1, nested hierarchy)

Ah, didn't notice the TODO. Is there a spec file on how this is planned to be handled? Right now it seems you will just create domains under ROOT behind-the-scenes?


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Ian Duffy <ia...@ianduffy.ie>.

> On Oct. 23, 2013, 6:22 a.m., Prasanna Santhanam wrote:
> > How is the import behaviour when OUs contain other OUs?
> 
> Rajani Karuturi wrote:
>     That is still not done. (Its the second part of TODO:1, nested hierarchy)
> 
> Prasanna Santhanam wrote:
>     Ah, didn't notice the TODO. Is there a spec file on how this is planned to be handled? Right now it seems you will just create domains under ROOT behind-the-scenes?
> 
> Rajani Karuturi wrote:
>     Nothing yet. I will update the wiki page created by Ian https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+implementation+improvement+and+user+provisioning
>     Yes, right now it just imports the same hierarchy(1-level) to cloudstack under ROOT with the specified account type.

Thanks Rajani.
I will try look at this tonight, currently a bit tied with college assignments.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Ian Duffy <ia...@ianduffy.ie>.

> On Oct. 23, 2013, 6:22 a.m., Prasanna Santhanam wrote:
> > How is the import behaviour when OUs contain other OUs?
> 
> Rajani Karuturi wrote:
>     That is still not done. (Its the second part of TODO:1, nested hierarchy)
> 
> Prasanna Santhanam wrote:
>     Ah, didn't notice the TODO. Is there a spec file on how this is planned to be handled? Right now it seems you will just create domains under ROOT behind-the-scenes?
> 
> Rajani Karuturi wrote:
>     Nothing yet. I will update the wiki page created by Ian https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+implementation+improvement+and+user+provisioning
>     Yes, right now it just imports the same hierarchy(1-level) to cloudstack under ROOT with the specified account type.
> 
> Ian Duffy wrote:
>     Thanks Rajani.
>     I will try look at this tonight, currently a bit tied with college assignments.

This looks OK to me, other than the highlighted todos.
It would be nice to include a ou/nested-on in the flat ldif file(plugins/user-authenticators/ldap/test/resources) that the embedded apacheds server uses to populate.

@aprateek can I sign off on this or do you wish to look at it aswell?


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Rajani Karuturi <ra...@gmail.com>.

> On Oct. 23, 2013, 6:22 a.m., Prasanna Santhanam wrote:
> > How is the import behaviour when OUs contain other OUs?
> 
> Rajani Karuturi wrote:
>     That is still not done. (Its the second part of TODO:1, nested hierarchy)
> 
> Prasanna Santhanam wrote:
>     Ah, didn't notice the TODO. Is there a spec file on how this is planned to be handled? Right now it seems you will just create domains under ROOT behind-the-scenes?
> 
> Rajani Karuturi wrote:
>     Nothing yet. I will update the wiki page created by Ian https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP+implementation+improvement+and+user+provisioning
>     Yes, right now it just imports the same hierarchy(1-level) to cloudstack under ROOT with the specified account type.
> 
> Ian Duffy wrote:
>     Thanks Rajani.
>     I will try look at this tonight, currently a bit tied with college assignments.
> 
> Ian Duffy wrote:
>     This looks OK to me, other than the highlighted todos.
>     It would be nice to include a ou/nested-on in the flat ldif file(plugins/user-authenticators/ldap/test/resources) that the embedded apacheds server uses to populate.
>     
>     @aprateek can I sign off on this or do you wish to look at it aswell?

Thanks for the review Ian. 

Can one of you push this commit? It would make my further development easier.


- Rajani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 14867: api call to import ldap users to the same domains in cloudstack

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14867/#review27362
-----------------------------------------------------------


How is the import behaviour when OUs contain other OUs?

- Prasanna Santhanam


On Oct. 23, 2013, 5:26 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14867/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 5:26 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-4866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added an api call to import all the ldap users to the same domains(ou's) in cloudstack
>     
>         TODO:
>         1. error handling of no domains present, nested hierarchy
>         2. handling the case when the api call fails for a specific user/users
>         3. test cases for LdapUserManager
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/user/DomainService.java 7c302e3 
>   client/tomcatconf/commands.properties.in 0296de0 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java PRE-CREATION 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 9b21c8f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 0cfb37c 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java 87406ad 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUser.java 18ad7d9 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 7494346 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy c593959 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapImportUsersCmdSpec.groovy PRE-CREATION 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListUsersCmdSpec.groovy 5039443 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapManagerImplSpec.groovy d681eac 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy fce299d 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserResponseSpec.groovy f1978fa 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy 8fd1ccc 
>   server/src/com/cloud/user/DomainManagerImpl.java b885c48 
>   server/test/com/cloud/user/MockDomainManagerImpl.java 616e12d 
> 
> Diff: https://reviews.apache.org/r/14867/diff/
> 
> 
> Testing
> -------
> 
> testing is done except for LdapUserManager(for which i am facing some issues locally) and DomainService(for which no test cases exist currently)
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>