[GitHub] [incubator-openwhisk] ddragosd commented on a change in pull request #4484: Switch to consistent indexing policy for CosmosDB

[GitBox <gi...@apache.org>]

ddragosd commented on a change in pull request #4484: Switch to consistent indexing policy for CosmosDB
URL: https://github.com/apache/incubator-openwhisk/pull/4484#discussion_r286121805
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBSupport.scala
 ##########
 @@ -17,13 +17,14 @@
 
 package org.apache.openwhisk.core.database.cosmosdb
 
+import akka.event.slf4j.SLF4JLogging
 import com.microsoft.azure.cosmosdb._
 import com.microsoft.azure.cosmosdb.rx.AsyncDocumentClient
 
 import scala.collection.JavaConverters._
 import scala.collection.immutable
 
-private[cosmosdb] trait CosmosDBSupport extends RxObservableImplicits with CosmosDBUtil {
+private[cosmosdb] trait CosmosDBSupport extends RxObservableImplicits with CosmosDBUtil with SLF4JLogging {
 
 Review comment:
   Besides consistency, is there a concern for passing `implicit` vs using `SLF4JLogging` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services