You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/09/23 15:55:53 UTC

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3929: Rewrote /user/reset_password to Go

rob05c commented on a change in pull request #3929: Rewrote /user/reset_password to Go
URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r327196028
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/traffic_ops/config.sh
 ##########
 @@ -122,7 +122,13 @@ cat <<-EOF >/opt/traffic_ops/app/conf/cdn.conf
     "geniso" : {
         "iso_root_path" : "/opt/traffic_ops/app/public"
     },
-    "inactivity_timeout" : 60
+    "inactivity_timeout" : 60,
+    "SMTP" : {
+        "Enabled" : false,
 
 Review comment:
   +1 on keeping the case consistent in the config file, i.e. using snake_case everywhere.
   
   -1 on unmarshalling in Go without struct tags anyway. Explicit is better than Implicit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services