You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/08 09:42:13 UTC

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #4258: [Polish] Optimized code

Oliverwqcwrw commented on code in PR #4258:
URL: https://github.com/apache/rocketmq/pull/4258#discussion_r867464047


##########
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java:
##########
@@ -417,7 +417,7 @@ public void createTopic(String key, String newTopic, int queueNum) throws MQClie
     @Override
     public void setUseTLS(boolean useTLS) {
         super.setUseTLS(useTLS);
-        if (traceDispatcher != null && traceDispatcher instanceof AsyncTraceDispatcher) {

Review Comment:
   IMO,Null is not an instanceof anything, so a null check is redundant.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org