[GitHub] [incubator-iceberg] mccheah opened a new pull request #152: Applies Baseline to iceberg-common and fixes applying Baseline to Iceberg-api

[GitBox <gi...@apache.org>]

mccheah opened a new pull request #152: Applies Baseline to iceberg-common and fixes applying Baseline to Iceberg-api
URL: https://github.com/apache/incubator-iceberg/pull/152
 
 
   This applies the Baseline plugins for the iceberg-common project.
   
   Additionally, there was an error in how we applied the Baseline plugin to iceberg-api in the first place. The manner in which we applied the plugin appeared to make the plugin not actually take effect at all. This PR significantly changes the way we apply Baseline in order to get the right behavior. Now:
   
   - `./gradle check` depends on all the linting tasks
   - Added the Spotless plugin, which is what would normally be used by `com.palantir.baseline-format`, but we change the formatting rules to put static imports after non-static imports. Now, one can also run `./gradlew spotlessApply` to automatically some classes of formatting errors.
   - Applies all of the Baseline plugins manually, rather than applying the blanket `baseline` plugin - this is to opt-out of the `baseline-format` plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org