[GitHub] EmergentOrder commented on a change in pull request #9339: Update dependencies / Makefile + add Maven profile to support build with Scala 2.12

[GitBox <gi...@apache.org>]

EmergentOrder commented on a change in pull request #9339: Update dependencies / Makefile + add Maven profile to support build with Scala 2.12
URL: https://github.com/apache/incubator-mxnet/pull/9339#discussion_r160280321
 
 

 ##########
 File path: scala-package/pom.xml
 ##########
 @@ -112,6 +112,44 @@
         </plugins>
       </build>
     </profile>
+
+    <profile>
+      <id>scala-2.11</id>
+    </profile>
+
+    <profile>
+      <id>scala-2.12</id>
+      <properties>
+        <scala.version>2.12.4</scala.version>
+        <scala.binary.version>2.12</scala.binary.version>
+      </properties>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-enforcer-plugin</artifactId>
 
 Review comment:
   To ensure that no Scala 2.10 or 2.11 versioned dependencies are pulled in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services