You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Yoshikazu Nojima <ma...@ynojima.net> on 2013/11/05 22:31:02 UTC
Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe VNI
allocation matter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/
-----------------------------------------------------------
Review request for cloudstack and Marcus Sorensen.
Bugs: CLOUDSTACK-4967
https://issues.apache.org/jira/browse/CLOUDSTACK-4967
Repository: cloudstack-docs
Description
-------
This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
- Add a section to describe VNIs allocation matter
- Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
- Update screen shots to catch up new UI visual appearance.
Diffs
-----
vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
Diff: https://reviews.apache.org/r/15247/diff/
Testing
-------
I generated and confirmed the PDF.
Thanks,
Yoshikazu Nojima
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to
describe VNI allocation matter
Posted by Toshiaki Hatano <ha...@haeena.net>.
It's already committed :)
> commit 002c2b22f43f7ace0ade652e92c2d46b92c3136f in 4.3
--
Toshiaki
2014-01-24 Radhika Puthiyetath <ra...@citrix.com>
> Please apply this patch to 4.3 branch as well.
>
> -----Original Message-----
> From: Toshiaki Hatano [mailto:noreply@reviews.apache.org] On Behalf Of
> Toshiaki Hatano
> Sent: Thursday, January 23, 2014 10:53 PM
> To: Marcus Sorensen; Toshiaki Hatano
> Cc: Yoshikazu Nojima; cloudstack
> Subject: Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to
> describe VNI allocation matter
>
>
>
> > On Jan. 23, 2014, 5:08 p.m., Toshiaki Hatano wrote:
> > > Ship It!
>
> applied to master and 4.3.
> commit c9b8bc0884e9e1166046bfdd1354a991d39d7d71 in master commit
> 002c2b22f43f7ace0ade652e92c2d46b92c3136f in 4.3
>
>
> - Toshiaki
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/#review32625
> -----------------------------------------------------------
>
>
> On Jan. 22, 2014, 5:44 a.m., Yoshikazu Nojima wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/15247/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 22, 2014, 5:44 a.m.)
> >
> >
> > Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
> >
> >
> > Bugs: CLOUDSTACK-4967
> > https://issues.apache.org/jira/browse/CLOUDSTACK-4967
> >
> >
> > Repository: cloudstack-docs
> >
> >
> > Description
> > -------
> >
> > This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
> >
> > - Add a section to describe VNIs allocation matter
> > - Remove section that explain how to configure the bridge for traffic
> label because the bridge configuration is no longer necessary.
> > - Update screen shots to catch up new UI visual appearance.
> >
> >
> > Diffs
> > -----
> >
> > vxlan/en-US/images/vxlan-physicalnetwork.png
> e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> > vxlan/en-US/images/vxlan-trafficlabel.png
> 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> > vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> > vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> > vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> > vxlan/en-US/plugin-vxlan-requirements.xml c2e04a6
> > vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
> >
> > Diff: https://reviews.apache.org/r/15247/diff/
> >
> >
> > Testing
> > -------
> >
> > I generated and confirmed the PDF.
> >
> >
> > Thanks,
> >
> > Yoshikazu Nojima
> >
> >
>
>
RE: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to
describe VNI allocation matter
Posted by Radhika Puthiyetath <ra...@citrix.com>.
Please apply this patch to 4.3 branch as well.
-----Original Message-----
From: Toshiaki Hatano [mailto:noreply@reviews.apache.org] On Behalf Of Toshiaki Hatano
Sent: Thursday, January 23, 2014 10:53 PM
To: Marcus Sorensen; Toshiaki Hatano
Cc: Yoshikazu Nojima; cloudstack
Subject: Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe VNI allocation matter
> On Jan. 23, 2014, 5:08 p.m., Toshiaki Hatano wrote:
> > Ship It!
applied to master and 4.3.
commit c9b8bc0884e9e1166046bfdd1354a991d39d7d71 in master commit 002c2b22f43f7ace0ade652e92c2d46b92c3136f in 4.3
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/#review32625
-----------------------------------------------------------
On Jan. 22, 2014, 5:44 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 5:44 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-docs
>
>
> Description
> -------
>
> This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
>
> - Add a section to describe VNIs allocation matter
> - Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
> - Update screen shots to catch up new UI visual appearance.
>
>
> Diffs
> -----
>
> vxlan/en-US/images/vxlan-physicalnetwork.png e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> vxlan/en-US/plugin-vxlan-requirements.xml c2e04a6
> vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
>
> Diff: https://reviews.apache.org/r/15247/diff/
>
>
> Testing
> -------
>
> I generated and confirmed the PDF.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Jan. 23, 2014, 5:08 p.m., Toshiaki Hatano wrote:
> > Ship It!
applied to master and 4.3.
commit c9b8bc0884e9e1166046bfdd1354a991d39d7d71 in master
commit 002c2b22f43f7ace0ade652e92c2d46b92c3136f in 4.3
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/#review32625
-----------------------------------------------------------
On Jan. 22, 2014, 5:44 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 5:44 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-docs
>
>
> Description
> -------
>
> This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
>
> - Add a section to describe VNIs allocation matter
> - Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
> - Update screen shots to catch up new UI visual appearance.
>
>
> Diffs
> -----
>
> vxlan/en-US/images/vxlan-physicalnetwork.png e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> vxlan/en-US/plugin-vxlan-requirements.xml c2e04a6
> vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
>
> Diff: https://reviews.apache.org/r/15247/diff/
>
>
> Testing
> -------
>
> I generated and confirmed the PDF.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Toshiaki Hatano <ha...@haeena.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/#review32625
-----------------------------------------------------------
Ship it!
Ship It!
- Toshiaki Hatano
On Jan. 22, 2014, 5:44 a.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 5:44 a.m.)
>
>
> Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-docs
>
>
> Description
> -------
>
> This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
>
> - Add a section to describe VNIs allocation matter
> - Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
> - Update screen shots to catch up new UI visual appearance.
>
>
> Diffs
> -----
>
> vxlan/en-US/images/vxlan-physicalnetwork.png e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
> vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> vxlan/en-US/plugin-vxlan-requirements.xml c2e04a6
> vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
>
> Diff: https://reviews.apache.org/r/15247/diff/
>
>
> Testing
> -------
>
> I generated and confirmed the PDF.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 5:44 a.m.)
Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
Changes
-------
- update Linux distribution list to include CentOS 6.5
Bugs: CLOUDSTACK-4967
https://issues.apache.org/jira/browse/CLOUDSTACK-4967
Repository: cloudstack-docs
Description
-------
This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
- Add a section to describe VNIs allocation matter
- Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
- Update screen shots to catch up new UI visual appearance.
Diffs (updated)
-----
vxlan/en-US/images/vxlan-physicalnetwork.png e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
vxlan/en-US/plugin-vxlan-requirements.xml c2e04a6
vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
Diff: https://reviews.apache.org/r/15247/diff/
Testing
-------
I generated and confirmed the PDF.
Thanks,
Yoshikazu Nojima
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 5:04 a.m.)
Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano.
Changes
-------
- keep the section describes the way to use a bridge as a traffic label left.
- fix the typo (XVLAN -> VXLAN)
# So sorry for belated update.
Bugs: CLOUDSTACK-4967
https://issues.apache.org/jira/browse/CLOUDSTACK-4967
Repository: cloudstack-docs
Description
-------
This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
- Add a section to describe VNIs allocation matter
- Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
- Update screen shots to catch up new UI visual appearance.
Diffs (updated)
-----
vxlan/en-US/images/vxlan-physicalnetwork.png e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
Diff: https://reviews.apache.org/r/15247/diff/
Testing
-------
I generated and confirmed the PDF.
Thanks,
Yoshikazu Nojima
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Nov. 7, 2013, 4:32 p.m., Toshiaki Hatano wrote:
> > This modification basically subtract contents from the doc but the patch actually add a option to use physical interface name for traffic label.
> > Since we still allow user to use bridge (even if it's not optimal) as traffic label, why don't we add more documentation to tell options and pros/cons instead of concealing things.
Or, just make bridge-named traffic label invalid for vxlan isolation and write so.
(it's better option for users, might be)
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/#review28374
-----------------------------------------------------------
On Nov. 5, 2013, 9:31 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 9:31 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-docs
>
>
> Description
> -------
>
> This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
>
> - Add a section to describe VNIs allocation matter
> - Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
> - Update screen shots to catch up new UI visual appearance.
>
>
> Diffs
> -----
>
> vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
>
> Diff: https://reviews.apache.org/r/15247/diff/
>
>
> Testing
> -------
>
> I generated and confirmed the PDF.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Amogh Vasekar <am...@citrix.com>.
> On Nov. 7, 2013, 4:32 p.m., Toshiaki Hatano wrote:
> > vxlan/en-US/plugin-vxlan-config-hypervisor.xml, line 30
> > <https://reviews.apache.org/r/15247/diff/1/?file=378377#file378377line30>
> >
> > This paragraph excluding line 32 is still valid after the patch.
> >
> > IMO it's better to explain why we need to open UDP/8472 port.
> > I also feel it's must to explain this plugin require multicast reachability between underlying interfaces, at least somewhere in this document.
> >
Reminder -
This review has been pending for long. Please mark the review as submitted if this has been committed already
Thanks!
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/#review28374
-----------------------------------------------------------
On Nov. 5, 2013, 9:31 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 9:31 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-docs
>
>
> Description
> -------
>
> This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
>
> - Add a section to describe VNIs allocation matter
> - Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
> - Update screen shots to catch up new UI visual appearance.
>
>
> Diffs
> -----
>
> vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
>
> Diff: https://reviews.apache.org/r/15247/diff/
>
>
> Testing
> -------
>
> I generated and confirmed the PDF.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>
Re: Review Request 15247: [DOC] CLOUDSTACK-4967: Add a section to describe
VNI allocation matter
Posted by Toshiaki Hatano <ha...@haeena.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15247/#review28374
-----------------------------------------------------------
This modification basically subtract contents from the doc but the patch actually add a option to use physical interface name for traffic label.
Since we still allow user to use bridge (even if it's not optimal) as traffic label, why don't we add more documentation to tell options and pros/cons instead of concealing things.
vxlan/en-US/plugin-vxlan-config-hypervisor.xml
<https://reviews.apache.org/r/15247/#comment55191>
s/XVLAN/VXLAN/ ? :)
vxlan/en-US/plugin-vxlan-config-hypervisor.xml
<https://reviews.apache.org/r/15247/#comment55194>
This paragraph excluding line 32 is still valid after the patch.
IMO it's better to explain why we need to open UDP/8472 port.
I also feel it's must to explain this plugin require multicast reachability between underlying interfaces, at least somewhere in this document.
- Toshiaki Hatano
On Nov. 5, 2013, 9:31 p.m., Yoshikazu Nojima wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15247/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 9:31 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Bugs: CLOUDSTACK-4967
> https://issues.apache.org/jira/browse/CLOUDSTACK-4967
>
>
> Repository: cloudstack-docs
>
>
> Description
> -------
>
> This patch updates CloudStack Plugin Guide for the VXLAN Plugin.
>
> - Add a section to describe VNIs allocation matter
> - Remove section that explain how to configure the bridge for traffic label because the bridge configuration is no longer necessary.
> - Update screen shots to catch up new UI visual appearance.
>
>
> Diffs
> -----
>
> vxlan/en-US/images/vxlan-trafficlabel.png 956d5f4f58f592ed3f260d6e1982c238c2ddf06a
> vxlan/en-US/images/vxlan-vniconfig.png PRE-CREATION
> vxlan/en-US/plugin-vxlan-config-hypervisor.xml 2c5e138
> vxlan/en-US/plugin-vxlan-config-management.xml 21f5461
> vxlan/en-US/plugin-vxlan-revision-history.xml ec04d11
>
> Diff: https://reviews.apache.org/r/15247/diff/
>
>
> Testing
> -------
>
> I generated and confirmed the PDF.
>
>
> Thanks,
>
> Yoshikazu Nojima
>
>