You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by Laura Stewart <sc...@gmail.com> on 2007/03/14 16:40:41 UTC

Deleted files in a patch aren't showing up as deleted

For Derby-1920, there is a patch (derby-1920-ref8.diffs)  that is
supposed to contain several deleted files.
However when I do svn stat, they show up as modified:

A      src\ref\rrefjdbc2_0summary.dita
M      src\ref\rrefsqlj11277.dita
M      src\ref\rrefsqlj26498.dita
M      src\ref\rrefsqlj87167.dita
M      src\ref\rrefsqlj1080779.dita
M      src\ref\rrefsqlj1080962.dita
M      src\ref\rrefsqlj76354.dita
M      src\ref\refderby.ditamap

The files that should be deleted are:
src/ref/rrefsqlj76354.dita
src/ref/rrefsqlj87167.dita
src/ref/rrefsqlj1080962.dita

Should I ask someone else to check this patch, have the contributor
recreate it, or ???

-- 
Laura Stewart

Re: Deleted files in a patch aren't showing up as deleted

Posted by Laura Stewart <sc...@gmail.com>.
On 3/14/07, Bryan Pendleton <bp...@amberpoint.com> wrote:
> > supposed to contain several deleted files.
> > However when I do svn stat, they show up as modified:
>
> Do you mean that you grabbed a patch that was attached to
> a JIRA issue, applied it to your sandbox with patch, and
> the stat doesn't look right?
>
> You have to explicitly do the 'svn delete' yourself.
>
> See: http://wiki.apache.org/db-derby/AddedOrDeletedFilesInDiff

Thanks Bryan, I've only commited patches with deleted files that were
my own patches, so this was new to me :-)
The link clearly states what to do. I think I will add a link to it
from the Derby Documentation Web page (and add this specifically to my
local cheat sheet).

BIG HELP!

-- 
Laura Stewart

Re: Deleted files in a patch aren't showing up as deleted

Posted by Bryan Pendleton <bp...@amberpoint.com>.
> supposed to contain several deleted files.
> However when I do svn stat, they show up as modified:

Do you mean that you grabbed a patch that was attached to
a JIRA issue, applied it to your sandbox with patch, and
the stat doesn't look right?

You have to explicitly do the 'svn delete' yourself.

See: http://wiki.apache.org/db-derby/AddedOrDeletedFilesInDiff

thanks,

bryan