[GitHub] brownscott commented on issue #527: HDDS-1093. Configuration tab in OM/SCM ui is not displaying the correct values

[GitBox <gi...@apache.org>]

brownscott commented on issue #527: HDDS-1093. Configuration tab in OM/SCM ui is not displaying the correct values
URL: https://github.com/apache/hadoop/pull/527#issuecomment-468104921
 
 
   
   -- 
   Sent from my Android phone with GMX Mail. Please excuse my brevity.On 2019-02-27, 9:55 p.m. Siddharth <no...@github.com> wrote:
   @swagle commented on this pull request.
   
   
   
   In hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/conf/TestOzoneConfiguration.java:
   > +import org.junit.Assert;
   +import org.junit.Before;
   +import org.junit.Test;
   +
   +import java.io.BufferedWriter;
   +import java.io.File;
   +import java.io.FileWriter;
   +import java.io.IOException;
   +
   +public class TestOzoneConfiguration {
   +
   +  private Configuration conf;
   +  final static String CONFIG = new File("./test-config-TestConfiguration.xml").getAbsolutePath();
   +  final static String CONFIG_CORE = new File("./core-site.xml").getAbsolutePath();
   +
   +  private BufferedWriter out;
   
   In general not too excited about sharing streams as a coding best practice, others reviewers can chime in but better to localize this vs deal with side effect code in tearDown.
   
   —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
   {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/apache/hadoop","title":"apache/hadoop","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/apache/hadoop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@swagle commented on #527"}],"action":{"name":"View Pull Request","url":"https://github.com/apache/hadoop/pull/527#pullrequestreview-208858889"}}}
   [
   {
   "@context": "http://schema.org",
   "@type": "EmailMessage",
   "potentialAction": {
   "@type": "ViewAction",
   "target": "https://github.com/apache/hadoop/pull/527#pullrequestreview-208858889",
   "url": "https://github.com/apache/hadoop/pull/527#pullrequestreview-208858889",
   "name": "View Pull Request"
   },
   "description": "View this Pull Request on GitHub",
   "publisher": {
   "@type": "Organization",
   "name": "GitHub",
   "url": "https://github.com"
   }
   }
   ]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org