You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andrew Lamb (Jira)" <ji...@apache.org> on 2021/04/26 12:43:02 UTC
[jira] [Commented] (ARROW-10980) [Rust] Document use of unsafe in
src/array/*.rs
[ https://issues.apache.org/jira/browse/ARROW-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332178#comment-17332178 ]
Andrew Lamb commented on ARROW-10980:
-------------------------------------
Migrated to github: https://github.com/apache/arrow-rs/issues/149
> [Rust] Document use of unsafe in src/array/*.rs
> -----------------------------------------------
>
> Key: ARROW-10980
> URL: https://issues.apache.org/jira/browse/ARROW-10980
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Rust
> Reporter: Andy Grove
> Priority: Major
>
> This needs to be broken down into smaller tasks
>
> There are ~32 uses of unsafe insrc/array/*.rs and we should document them according to the guidelines in the Arrow crate README
>
> {code:java}
> // JUSTIFICATION
> // Benefit
> // Describe the benefit of using unsafe. E.g.
> // "30% performance degradation if the safe counterpart is used, see bench X."
> // Soundness
> // Describe why the code remains sound (according to the definition of rust's unsafe code guidelines). E.g.
> // "We bounded check these values at initialization and the array is immutable."
> let ... = unsafe { ... }; {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)