You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (Created) (JIRA)" <ji...@apache.org> on 2011/11/23 16:37:39 UTC
[jira] [Created] (SLING-2299) Consolidate constants and utility
methods
Consolidate constants and utility methods
-----------------------------------------
Key: SLING-2299
URL: https://issues.apache.org/jira/browse/SLING-2299
Project: Sling
Issue Type: Improvement
Components: Authentication
Affects Versions: Auth Core 1.0.6
Reporter: Felix Meschberger
Assignee: Felix Meschberger
Fix For: Auth Core 1.1.0
Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2299) Consolidate constants and utility
methods
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155923#comment-13155923 ]
Felix Meschberger commented on SLING-2299:
------------------------------------------
Implemented this consolidation in Rev. 1205454
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2299) Consolidate constants and utility
methods
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156249#comment-13156249 ]
Felix Meschberger commented on SLING-2299:
------------------------------------------
Same for RedirectOnLoginErrorTest: fixed in Rev. 1205563
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2299) Consolidate constants and utility
methods
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-2299.
--------------------------------------
Resolution: Fixed
I think this is complete for now. Lets resolve it and have other issues created if something comes up again.
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2299) Consolidate constants and utility
methods
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156246#comment-13156246 ]
Felix Meschberger commented on SLING-2299:
------------------------------------------
AuthenticationResponseCode tests failed due to the fixed browser recognition of the Sling Authenticator. Fixed in Rev. 1205559 and 1205562
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2299) Consolidate constants and utility
methods
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155925#comment-13155925 ]
Felix Meschberger commented on SLING-2299:
------------------------------------------
Fixed uses of AuthUtil.checkReferer in the Form, OpenID, and Login Selector handlers in Rev. 1205458. This method has been moved from AbstractAuthenticationHandler (instead of copied and deprecated) because it was not contained in a release version of the bundle yet.
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2299) Consolidate constants and utility
methods
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504469#comment-13504469 ]
Carsten Ziegeler commented on SLING-2299:
-----------------------------------------
Is there anything left to do here?
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and we have a number of utility methods in the AbstractAuthenticationHandler. There is even a duplicate isBrowserRequest method in the SlingAuthenticator class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant or utility method, we have to increase the minor version of the exported package. If this happens on the spi package this would cause all implementations to become incompatible, even though they are not. By having these methods in a separate exported package which containing a single interface not intended to be implemented outside of the auth core bundle, we can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira