You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/26 16:30:18 UTC
Review Request 63272: Windows: Added `os::get_job_info` to stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63272/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
Repository: mesos
Description
-------
This returns a `JOBOBJECT_BASIC_ACCOUNTING_INFORMATION`, which can be
inspected for basic CPU / process accounting information for a group of
processes within a job object.
Diffs
-----
3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
Diff: https://reviews.apache.org/r/63272/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63272/#review189740
-----------------------------------------------------------
Ship it!
Ship It!
- Jeff Coffler
On Oct. 31, 2017, 5:51 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63272/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2017, 5:51 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This returns a `JOBOBJECT_BASIC_ACCOUNTING_INFORMATION`, which can be
> inspected for basic CPU / process accounting information for a group of
> processes within a job object.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
>
>
> Diff: https://reviews.apache.org/r/63272/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63272/
-----------------------------------------------------------
(Updated Oct. 31, 2017, 10:51 a.m.)
Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
Changes
-------
Added NOLINT to lines longer than 80 char because of URLs.
Repository: mesos
Description
-------
This returns a `JOBOBJECT_BASIC_ACCOUNTING_INFORMATION`, which can be
inspected for basic CPU / process accounting information for a group of
processes within a job object.
Diffs (updated)
-----
3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
Diff: https://reviews.apache.org/r/63272/diff/2/
Changes: https://reviews.apache.org/r/63272/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.
Posted by Jeff Coffler <je...@taltos.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63272/#review189343
-----------------------------------------------------------
3rdparty/stout/include/stout/windows/os.hpp
Lines 730 (patched)
<https://reviews.apache.org/r/63272/#comment266362>
This line is > 80 bytes, needs `NOLINT` added.
- Jeff Coffler
On Oct. 26, 2017, 4:30 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63272/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 4:30 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, John Kordich, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This returns a `JOBOBJECT_BASIC_ACCOUNTING_INFORMATION`, which can be
> inspected for basic CPU / process accounting information for a group of
> processes within a job object.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows/os.hpp 09ddec6d69472cd13b453fe1a77fdbe343fc23c8
>
>
> Diff: https://reviews.apache.org/r/63272/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>