You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@airflow.apache.org by Chad Henderson <ch...@gritlogic.com> on 2017/01/29 03:26:11 UTC

SQL Syntax Errors in 1.8

Hi everyone,

Is it too late to get big fixes into 1.8? I have a PR hanging out there
that resolves an issue with SqlAlchemy translation is_(False) to an IS 0
which is not a thing in tSQL.

PR: https://github.com/apache/incubator-airflow/pull/2022

Thanks,

Chad

Re: SQL Syntax Errors in 1.8

Posted by Chad Henderson <ch...@gritlogic.com>.

Sounds good to me.

On Jan 29, 2017 2:41 AM, "Bolke de Bruin" <bd...@gmail.com> wrote:

> Hey Chad,
>
> I saw that PR and I am a bit hesitant to include in 1.8.0, as it is indeed
> rather big and it touches core functionality. What about targeting it for
> 1.8.1, which should be ~1 month after?
>
> Cheers
> Bolke
>
> > On 29 Jan 2017, at 04:26, Chad Henderson <ch...@gritlogic.com>
> wrote:
> >
> > Hi everyone,
> >
> > Is it too late to get big fixes into 1.8? I have a PR hanging out there
> > that resolves an issue with SqlAlchemy translation is_(False) to an IS 0
> > which is not a thing in tSQL.
> >
> > PR: https://github.com/apache/incubator-airflow/pull/2022
> >
> > Thanks,
> >
> > Chad
>
>

Re: SQL Syntax Errors in 1.8

Posted by Bolke de Bruin <bd...@gmail.com>.

Hey Chad,

I saw that PR and I am a bit hesitant to include in 1.8.0, as it is indeed rather big and it touches core functionality. What about targeting it for 1.8.1, which should be ~1 month after?

Cheers
Bolke

> On 29 Jan 2017, at 04:26, Chad Henderson <ch...@gritlogic.com> wrote:
> 
> Hi everyone,
> 
> Is it too late to get big fixes into 1.8? I have a PR hanging out there
> that resolves an issue with SqlAlchemy translation is_(False) to an IS 0
> which is not a thing in tSQL.
> 
> PR: https://github.com/apache/incubator-airflow/pull/2022
> 
> Thanks,
> 
> Chad