You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/01 18:33:15 UTC
[GitHub] [nifi] mattyb149 opened a new pull request, #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
mattyb149 opened a new pull request, #6264:
URL: https://github.com/apache/nifi/pull/6264
# Summary
[NIFI-10306](https://issues.apache.org/jira/browse/NIFI-10306) This PR adds logging to better identify the components of a Connection that cannot be added to the flow, to include source and destination process groups and types, plus the reason.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [x] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
URL: https://github.com/apache/nifi/pull/6264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6264:
URL: https://github.com/apache/nifi/pull/6264#discussion_r954426618
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##########
@@ -1146,42 +1146,75 @@ public void addConnection(final Connection connection) {
if (isInputPort(source)) { // if source is an input port, its destination must be in the same group unless it's an input port
if (isInputPort(destination)) { // if destination is input port, it must be in a child group.
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (sourceGroup != this || destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source and destination are not both in this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source and destination are not both in this Process Group");
}
} else if (isOutputPort(source)) {
// if source is an output port, its group must be a child of this group, and its destination must be in this
// group (processor/output port) or a child group (input port)
if (!processGroups.containsKey(sourceGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source is an Output Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source is an Output Port that does not belong to a child Process Group");
}
if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] does not belong to this Process Group");
}
} else { // source is not a port
if (sourceGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because the source does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because the source does not belong to this Process Group");
}
if (isOutputPort(destination)) {
if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Output Port but does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Output Port that does not belong to this Process Group");
}
} else if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input "
- + "Port but the Input Port does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Input Port but the Input Port does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection between " + source.getIdentifier() + " and " + destination.getIdentifier()
- + " because they are in different Process Groups and neither is an Input Port or Output Port");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination " + destination.getConnectableType().name() + "[" + destination.getIdentifier() +
Review Comment:
Thanks for evaluating the options @mattyb149, on further review, keeping the messages as implemented sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a diff in pull request #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on code in PR #6264:
URL: https://github.com/apache/nifi/pull/6264#discussion_r945323865
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##########
@@ -1146,42 +1146,75 @@ public void addConnection(final Connection connection) {
if (isInputPort(source)) { // if source is an input port, its destination must be in the same group unless it's an input port
if (isInputPort(destination)) { // if destination is input port, it must be in a child group.
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (sourceGroup != this || destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source and destination are not both in this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source and destination are not both in this Process Group");
}
} else if (isOutputPort(source)) {
// if source is an output port, its group must be a child of this group, and its destination must be in this
// group (processor/output port) or a child group (input port)
if (!processGroups.containsKey(sourceGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source is an Output Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source is an Output Port that does not belong to a child Process Group");
}
if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] does not belong to this Process Group");
}
} else { // source is not a port
if (sourceGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because the source does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because the source does not belong to this Process Group");
}
if (isOutputPort(destination)) {
if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Output Port but does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Output Port that does not belong to this Process Group");
}
} else if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input "
- + "Port but the Input Port does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Input Port but the Input Port does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection between " + source.getIdentifier() + " and " + destination.getIdentifier()
- + " because they are in different Process Groups and neither is an Input Port or Output Port");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination " + destination.getConnectableType().name() + "[" + destination.getIdentifier() +
Review Comment:
The others should have the connectable type hard-coded into the string. I can change them all in order to externalize a method that takes the groups and such as arguments and return the formatted string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6264:
URL: https://github.com/apache/nifi/pull/6264#discussion_r937022324
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##########
@@ -1146,42 +1146,75 @@ public void addConnection(final Connection connection) {
if (isInputPort(source)) { // if source is an input port, its destination must be in the same group unless it's an input port
if (isInputPort(destination)) { // if destination is input port, it must be in a child group.
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (sourceGroup != this || destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source and destination are not both in this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source and destination are not both in this Process Group");
}
} else if (isOutputPort(source)) {
// if source is an output port, its group must be a child of this group, and its destination must be in this
// group (processor/output port) or a child group (input port)
if (!processGroups.containsKey(sourceGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source is an Output Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source is an Output Port that does not belong to a child Process Group");
}
if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] does not belong to this Process Group");
}
} else { // source is not a port
if (sourceGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because the source does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because the source does not belong to this Process Group");
}
if (isOutputPort(destination)) {
if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Output Port but does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Output Port that does not belong to this Process Group");
}
} else if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input "
- + "Port but the Input Port does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Input Port but the Input Port does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection between " + source.getIdentifier() + " and " + destination.getIdentifier()
- + " because they are in different Process Groups and neither is an Input Port or Output Port");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination " + destination.getConnectableType().name() + "[" + destination.getIdentifier() +
Review Comment:
Is there a reason for including the Connectable Type name value in this message but not the others?
In light of the similarities, what do you think about creating a simple method for formatting the source and destination messages to ensure consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a diff in pull request #6264: NIFI-10306: Add logging to StandardProcessGroup.addConnection() with more details
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on code in PR #6264:
URL: https://github.com/apache/nifi/pull/6264#discussion_r954397087
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java:
##########
@@ -1146,42 +1146,75 @@ public void addConnection(final Connection connection) {
if (isInputPort(source)) { // if source is an input port, its destination must be in the same group unless it's an input port
if (isInputPort(destination)) { // if destination is input port, it must be in a child group.
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (sourceGroup != this || destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source and destination are not both in this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Input Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source and destination are not both in this Process Group");
}
} else if (isOutputPort(source)) {
// if source is an output port, its group must be a child of this group, and its destination must be in this
// group (processor/output port) or a child group (input port)
if (!processGroups.containsKey(sourceGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because source is an Output Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination [" + destination.getIdentifier() +
+ "] because source is an Output Port that does not belong to a child Process Group");
}
if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input Port that does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because destination [" + destination.getIdentifier() +
+ "] is an Input Port that does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection for Output Port[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] does not belong to this Process Group");
}
} else { // source is not a port
if (sourceGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because the source does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because the source does not belong to this Process Group");
}
if (isOutputPort(destination)) {
if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Output Port but does not belong to this Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Output Port that does not belong to this Process Group");
}
} else if (isInputPort(destination)) {
if (!processGroups.containsKey(destinationGroup.getIdentifier())) {
- throw new IllegalStateException("Cannot add Connection to Process Group because its destination is an Input "
- + "Port but the Input Port does not belong to a child Process Group");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] because its destination [" + destination.getIdentifier() +
+ "] is an Input Port but the Input Port does not belong to a child Process Group");
}
} else if (destinationGroup != this) {
- throw new IllegalStateException("Cannot add Connection between " + source.getIdentifier() + " and " + destination.getIdentifier()
- + " because they are in different Process Groups and neither is an Input Port or Output Port");
+ throw new IllegalStateException("Cannot add Connection from " + source.getConnectableType().name() + "[" + source.getIdentifier() +
+ "] from Process Group [" + sourceGroup.getIdentifier() +
+ "] to Process Group [" + destinationGroup.getIdentifier() +
+ "] destination " + destination.getConnectableType().name() + "[" + destination.getIdentifier() +
Review Comment:
Many of the messages are slightly different, I think the extracted method would be more awkward as you'd have to include multiple strings to be inserted in various spots. I'd prefer to keep this as-is if that's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org