You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/02/15 14:10:52 UTC
[GitHub] [unomi] sergehuber opened a new pull request #250: UNOMI-431 Add initial proposal for PR template
sergehuber opened a new pull request #250:
URL: https://github.com/apache/unomi/pull/250
Currently we have no consistent pull request structure, although we do have processes that we'd like to have contributors follow.
The idea is to use Github's Pull Request Template feature to pre-populate each PR with a list of things to remember to do.
Please let me know what you think of it and any suggestions for improvement you might have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] Taybou commented on a change in pull request #250: UNOMI-431 Add initial proposal for PR template
Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #250:
URL: https://github.com/apache/unomi/pull/250#discussion_r576264885
##########
File path: .github/pull_request_template.md
##########
@@ -0,0 +1,33 @@
+PR Title format:
+
+ [UNOMI-XXX] Pull request title with JIRA reference
+
+**Please** add a meaningful description for your change here
+
+----
+
+**Please** following this checklist to help us incorporate your contribution quickly and easily:
+
+ - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/UNOMI) filed
+ for the change (usually before you start working on it). Trivial changes like typos do not
+ require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
+ - [ ] Format the pull request title like `[UNOMI-XXX] - Title of the pull request`
+ - [ ] Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
+ significant new parts of code.
+ - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
+ Copy the description to the related JIRA issue
+ - [ ] Run `mvn clean install -P integration-tests` to make sure basic checks pass. A more thorough check will be
+ performed on your pull request automatically.
+
+Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).
+
+If this is your first contribution, you have to read the [Contribution Guidelines](https://unomi.apache.org/contribute.html)
+
+If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
+if you are unsure please ask on the developers list.
+
+To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-box.
+
+ - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
+ - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Review comment:
why are there two checkboxes, maybe we should only keep one, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] Taybou merged pull request #250: UNOMI-431 Add initial proposal for PR template
Posted by GitBox <gi...@apache.org>.
Taybou merged pull request #250:
URL: https://github.com/apache/unomi/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on a change in pull request #250: UNOMI-431 Add initial proposal for PR template
Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #250:
URL: https://github.com/apache/unomi/pull/250#discussion_r576271365
##########
File path: .github/pull_request_template.md
##########
@@ -0,0 +1,33 @@
+PR Title format:
+
+ [UNOMI-XXX] Pull request title with JIRA reference
+
+**Please** add a meaningful description for your change here
+
+----
+
+**Please** following this checklist to help us incorporate your contribution quickly and easily:
+
+ - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/UNOMI) filed
+ for the change (usually before you start working on it). Trivial changes like typos do not
+ require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
+ - [ ] Format the pull request title like `[UNOMI-XXX] - Title of the pull request`
+ - [ ] Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
+ significant new parts of code.
+ - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
+ Copy the description to the related JIRA issue
+ - [ ] Run `mvn clean install -P integration-tests` to make sure basic checks pass. A more thorough check will be
+ performed on your pull request automatically.
+
+Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).
+
+If this is your first contribution, you have to read the [Contribution Guidelines](https://unomi.apache.org/contribute.html)
+
+If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
+if you are unsure please ask on the developers list.
+
+To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-box.
+
+ - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
+ - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Review comment:
Yes I think you're right I'll simplify this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org