You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/03 02:52:00 UTC
[jira] [Work logged] (BEAM-5619) Fix minor bug in JdbcIO example
code
[ https://issues.apache.org/jira/browse/BEAM-5619?focusedWorklogId=150588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150588 ]
ASF GitHub Bot logged work on BEAM-5619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/18 02:51
Start Date: 03/Oct/18 02:51
Worklog Time Spent: 10m
Work Description: sekikn opened a new pull request #6553: [BEAM-5619] Fix minor bug in JdbcIO example code
URL: https://github.com/apache/beam/pull/6553
**Please** add a meaningful description for your change here
Example code for writing to JDBC datasource in JdbcIO Javadoc doesn't work as it is now. This PR fixes it.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 150588)
Time Spent: 10m
Remaining Estimate: 0h
> Fix minor bug in JdbcIO example code
> ------------------------------------
>
> Key: BEAM-5619
> URL: https://issues.apache.org/jira/browse/BEAM-5619
> Project: Beam
> Issue Type: Bug
> Components: io-java-jdbc
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Trivial
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There's a minor bug in JdbcIO Javadoc:
> {code}
> 127 * <pre>{@code
> 128 * pipeline
> 129 * .apply(...)
> 130 * .apply(JdbcIO.<KV<Integer, String>>write()
> 131 * .withDataSourceConfiguration(JdbcIO.DataSourceConfiguration.create(
> 132 * "com.mysql.jdbc.Driver", "jdbc:mysql://hostname:3306/mydb")
> 133 * .withUsername("username")
> 134 * .withPassword("password"))
> 135 * .withStatement("insert into Person values(?, ?)")
> 136 * .withPreparedStatementSetter(new JdbcIO.PreparedStatementSetter<KV<Integer, String>>() {
> 137 * public void setParameters(KV<Integer, String> element, PreparedStatement query)
> 138 * throws SQLException {
> 139 * query.setInt(1, kv.getKey());
> 140 * query.setString(2, kv.getValue());
> 141 * }
> 142 * })
> 143 * );
> 144 * }</pre>
> {code}
> {{kv}} at the line 139 and 140 should be {{element}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)