You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/05/18 01:34:43 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #8850: Fix Rocky Linux 8 arm64 GCC Compiler Warnings

maskit commented on code in PR #8850:
URL: https://github.com/apache/trafficserver/pull/8850#discussion_r875394186


##########
iocore/eventsystem/I_Continuation.h:
##########
@@ -71,7 +71,7 @@ constexpr ContinuationHandler
 continuation_handler_void_ptr(int (C::*fp)(int, T *))
 {
   auto fp2 = reinterpret_cast<int (C::*)(int, void *)>(fp);
-  return static_cast<ContinuationHandler>(fp2);
+  return reinterpret_cast<ContinuationHandler>(fp2);

Review Comment:
   I happened to find this conversation (not watching changes to QUIC/H3 files 😎 ). I'm totally fine with switching the order of the parents, I wonder what would be the runtime difference though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org