You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2020/07/30 17:40:27 UTC
[Bug 64633] New: [PATCH] Support of function TEXTJOIN
https://bz.apache.org/bugzilla/show_bug.cgi?id=64633
Bug ID: 64633
Summary: [PATCH] Support of function TEXTJOIN
Product: POI
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: SS Common
Assignee: dev@poi.apache.org
Reporter: davegcodes@gmail.com
Target Milestone: ---
Created attachment 37377
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37377&action=edit
Implementation of TEXTJOIN
TEXTJOIN was added to Excel in 2016. It's used to concatenate strings with a
specified delimiter, and to optionally exclude arguments evaluating as empty:
https://support.microsoft.com/en-us/office/textjoin-function-357b449a-ec91-49d0-80c3-0e8fc845691c
The attached patch adds support for the TEXTJOIN function, as well as a suite
of unit tests for it.
First time submitting a POI patch, so please let me know if I've done something
incorrectly and I'm happy to fix it! Specifically, I wasn't sure the best way
to bind the new function class to the function name, so I cribbed off another
patch that added a new function via a binding in
AnalysisToolPak.createFunctionsMap.
The patch was created against trunk, but for my own project's use, I've applied
it back to 4.1.2, and that seems to work fine as well.
See also bug 60924. I filed this separately in the interest of an easy merge
since that one is a fairly old open bug with many functions listed, but if it's
better to include it in there, that works too.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 64633] [PATCH] Support of function TEXTJOIN
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64633
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
thanks - added with r1891855
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 64633] [PATCH] Support of function TEXTJOIN
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64633
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |60924
Referenced Bugs:
https://bz.apache.org/bugzilla/show_bug.cgi?id=60924
[Bug 60924] New Excel 2016 Statements Not Supported
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 64633] [PATCH] Support of function TEXTJOIN
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64633
--- Comment #2 from PJ Fanning <fa...@yahoo.com> ---
the patch did not support cell ranges - I have fixed one case using r1892061
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org