You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Colin Milhaupt <cm...@unm.edu> on 2023/01/07 01:33:10 UTC
Qpid Messaging API C++ MD5 Hash
Hello,
I was recently trying to build version 1.39 of the qpid messaging API on RHEL8 with FIPS mode enabled and was running into build issues. I unfortunately cannot change the security policy to anything else due to company constraints. Since MD5 is no longer a valid cryptographic hash function (not that isn't being used this way here), the script "schema.py" in the managementgen module was failing. To get around this, I changed the python script to use SHA256 instead and then updated all the references of MD5_LEN and accompanying arrays from 16 bytes to 32 bytes since the SHA256 digest length is twice as long. This worked, but I'd like to contribute the change upstream since I'm sure other will run into this problem. My proposals:
1. Add a cmake configuration flag to specify the hash digest to use with a default of MD5 which will configure the script "schema.py"
2. change all references of "MD5_LEN" and accompanying arrays to "DIGEST_LEN"
Any thoughts? Also, what's the contribution policy? I found https://github.com/apache/qpid-cpp, but are PRs accepted here?
Thanks,
Colin
Re: Qpid Messaging API C++ MD5 Hash
Posted by Robbie Gemmell <ro...@gmail.com>.
You should use users@ for most messages, dev@ is basically only used
for issue tracker updates etc, no discussion really happens there so
messages to it are actually more likely to be overlooked.
Use private@ for JIRA account requests as directed.
As to the original ask, you can certainly raise a PR at
https://github.com/apache/qpid-cpp but note traction is likely to be
low, qpid-cpp is essentially stagnant at this point as the commit
history shows. C++ client wise specifically, attention shifted away
from Qpid::Messaging C++ to the Qpid Proton C++ binding many years
ago.
Robbie
On Tue, 10 Jan 2023 at 10:58, Pete Fawcett <pe...@fawcett.co.uk> wrote:
>
> Hi Colin
>
> I can't give you an "official" answer about Qpid broker PRs, but I have
> made some contributions to Qpid Proton and the Qpid C++ broker in the past,
> most recently in May 2022.
>
> I suggest a good page to look at is the "Dashboard"
> https://qpid.apache.org/dashboard.html
>
> You found the right repo on GitHub. The workflow I used was as follows:
>
> - Open a Jira ticket (You can use the "Create Issue" link on the
> dashboard)
> - On GitHub, fork the qpid-cpp repo
> - Make your changes on this fork (I prefer to work on a branch that
> includes the ticket ID)
> - Submit a Pull Request from your fork back to the main repo
>
>
> To accomplish this, you will need both a GitHub account and an ASF Jira
> account. I notice that recently (November 2022) public sign-ups to ASF
> jira were disabled due to increasing spam. It looks like you need to email
> a request for an account. This article
> <https://infra.apache.org/jira-guidelines.html#who> has more details and
> implies that you need to email <pr...@qpid.apache.org> - though I would
> be tempted to copy <de...@qpid.apache.org> as well.
>
> In general, <de...@qpid.apache.org> is probably the better list to use for
> contributions.
>
> I hope that helps.
>
> Pete
>
>
>
> On Sat, 7 Jan 2023 at 01:42, Colin Milhaupt <cm...@unm.edu> wrote:
>
> > Hello,
> >
> > I was recently trying to build version 1.39 of the qpid messaging API on
> > RHEL8 with FIPS mode enabled and was running into build issues. I
> > unfortunately cannot change the security policy to anything else due to
> > company constraints. Since MD5 is no longer a valid cryptographic hash
> > function (not that isn't being used this way here), the script "schema.py"
> > in the managementgen module was failing. To get around this, I changed the
> > python script to use SHA256 instead and then updated all the references of
> > MD5_LEN and accompanying arrays from 16 bytes to 32 bytes since the SHA256
> > digest length is twice as long. This worked, but I'd like to contribute the
> > change upstream since I'm sure other will run into this problem. My
> > proposals:
> >
> > 1. Add a cmake configuration flag to specify the hash digest to use
> > with a default of MD5 which will configure the script "schema.py"
> > 2. change all references of "MD5_LEN" and accompanying arrays to
> > "DIGEST_LEN"
> >
> > Any thoughts? Also, what's the contribution policy? I found
> > https://github.com/apache/qpid-cpp, but are PRs accepted here?
> >
> > Thanks,
> >
> > Colin
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org
Re: Qpid Messaging API C++ MD5 Hash
Posted by Pete Fawcett <pe...@fawcett.co.uk>.
Hi Colin
I can't give you an "official" answer about Qpid broker PRs, but I have
made some contributions to Qpid Proton and the Qpid C++ broker in the past,
most recently in May 2022.
I suggest a good page to look at is the "Dashboard"
https://qpid.apache.org/dashboard.html
You found the right repo on GitHub. The workflow I used was as follows:
- Open a Jira ticket (You can use the "Create Issue" link on the
dashboard)
- On GitHub, fork the qpid-cpp repo
- Make your changes on this fork (I prefer to work on a branch that
includes the ticket ID)
- Submit a Pull Request from your fork back to the main repo
To accomplish this, you will need both a GitHub account and an ASF Jira
account. I notice that recently (November 2022) public sign-ups to ASF
jira were disabled due to increasing spam. It looks like you need to email
a request for an account. This article
<https://infra.apache.org/jira-guidelines.html#who> has more details and
implies that you need to email <pr...@qpid.apache.org> - though I would
be tempted to copy <de...@qpid.apache.org> as well.
In general, <de...@qpid.apache.org> is probably the better list to use for
contributions.
I hope that helps.
Pete
On Sat, 7 Jan 2023 at 01:42, Colin Milhaupt <cm...@unm.edu> wrote:
> Hello,
>
> I was recently trying to build version 1.39 of the qpid messaging API on
> RHEL8 with FIPS mode enabled and was running into build issues. I
> unfortunately cannot change the security policy to anything else due to
> company constraints. Since MD5 is no longer a valid cryptographic hash
> function (not that isn't being used this way here), the script "schema.py"
> in the managementgen module was failing. To get around this, I changed the
> python script to use SHA256 instead and then updated all the references of
> MD5_LEN and accompanying arrays from 16 bytes to 32 bytes since the SHA256
> digest length is twice as long. This worked, but I'd like to contribute the
> change upstream since I'm sure other will run into this problem. My
> proposals:
>
> 1. Add a cmake configuration flag to specify the hash digest to use
> with a default of MD5 which will configure the script "schema.py"
> 2. change all references of "MD5_LEN" and accompanying arrays to
> "DIGEST_LEN"
>
> Any thoughts? Also, what's the contribution policy? I found
> https://github.com/apache/qpid-cpp, but are PRs accepted here?
>
> Thanks,
>
> Colin
>