You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@empire-db.apache.org by Francis De Brabandere <fr...@gmail.com> on 2011/08/16 15:26:06 UTC
EMPIRE-99 merge to trunk?
There is one issue left causing a StringutilsTest to fail:
this used to return empty string but now return "null"
assertEquals("null",StringUtils.valueOf(null));
This used to return empty string but is now "null"
assertEquals("null",StringUtils.valueOf(new Object[]{}));
I changed the test to accept the new behavior but this is dangerous in
my eyes as this StringUtils is public and we might break existing
code.
Thanks Rainer for taking care of most of the refactorings, great we
got there! So shall we merge the branch to trunk now?
Greets,
Francis
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
Re: EMPIRE-99 merge to trunk?
Posted by Francis De Brabandere <fr...@gmail.com>.
no need for flattery, it was you who did the hard part :-)
On Tue, Aug 16, 2011 at 10:16 PM, Rainer Döbele <do...@esteam.de> wrote:
> Thanks Francis, you're a star (as always!)
>
> Rainer
>
>> from: Francis De Brabandere [mailto:francisdb@gmail.com]
>> to: empire-db-dev@incubator.apache.org
>> re: Re: EMPIRE-99 merge to trunk?
>>
>> I already fixed the examples an the codegen. I'll take care of the
>> merge.
>>
>> Cheers,
>> Francis
>>
>> On Tue, Aug 16, 2011 at 5:02 PM, Rainer Döbele <do...@esteam.de>
>> wrote:
>> > Hi Franics,
>> >
>> > thanks. I noticed the StringUtils issue - but needed a break.
>> > It's a matter of taste what the String representation of null should
>> be, and I am not sure whether I really want to keep it like this.
>> > For logging the value "null" is certainly better whereas for all
>> other purposes an empty string is preferable.
>> >
>> > Most of the work for EMPIREDB-99 has been done.
>> > Only the codegen and three sample projects are missing but should be
>> quite straigt forward to migrate.
>> >
>> > I have not been able to do a lot of testing, but I am confident that
>> most code will work as before.
>> >
>> > I would appreciate a merge with the trunk and Francis if you want to
>> do this, then please go ahead.
>> >
>> > I won't perform any more changes today.
>> >
>> > Regards
>> > Rainer
>> >
>> >
>> >> from: Francis De Brabandere [mailto:francisdb@gmail.com]
>> >> to: empire-db-dev@incubator.apache.org
>> >> re: EMPIRE-99 merge to trunk?
>> >>
>> >> There is one issue left causing a StringutilsTest to fail:
>> >>
>> >> this used to return empty string but now return "null"
>> >> assertEquals("null",StringUtils.valueOf(null));
>> >>
>> >> This used to return empty string but is now "null"
>> >> assertEquals("null",StringUtils.valueOf(new Object[]{}));
>> >>
>> >> I changed the test to accept the new behavior but this is dangerous
>> in
>> >> my eyes as this StringUtils is public and we might break existing
>> >> code.
>> >>
>> >> Thanks Rainer for taking care of most of the refactorings, great we
>> >> got there! So shall we merge the branch to trunk now?
>> >>
>> >> Greets,
>> >> Francis
>> >>
>> >> --
>> >> http://www.somatik.be
>> >> Microsoft gives you windows, Linux gives you the whole house.
>> >
>>
>>
>>
>> --
>> http://www.somatik.be
>> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
re: EMPIRE-99 merge to trunk?
Posted by Rainer Döbele <do...@esteam.de>.
Thanks Francis, you're a star (as always!)
Rainer
> from: Francis De Brabandere [mailto:francisdb@gmail.com]
> to: empire-db-dev@incubator.apache.org
> re: Re: EMPIRE-99 merge to trunk?
>
> I already fixed the examples an the codegen. I'll take care of the
> merge.
>
> Cheers,
> Francis
>
> On Tue, Aug 16, 2011 at 5:02 PM, Rainer Döbele <do...@esteam.de>
> wrote:
> > Hi Franics,
> >
> > thanks. I noticed the StringUtils issue - but needed a break.
> > It's a matter of taste what the String representation of null should
> be, and I am not sure whether I really want to keep it like this.
> > For logging the value "null" is certainly better whereas for all
> other purposes an empty string is preferable.
> >
> > Most of the work for EMPIREDB-99 has been done.
> > Only the codegen and three sample projects are missing but should be
> quite straigt forward to migrate.
> >
> > I have not been able to do a lot of testing, but I am confident that
> most code will work as before.
> >
> > I would appreciate a merge with the trunk and Francis if you want to
> do this, then please go ahead.
> >
> > I won't perform any more changes today.
> >
> > Regards
> > Rainer
> >
> >
> >> from: Francis De Brabandere [mailto:francisdb@gmail.com]
> >> to: empire-db-dev@incubator.apache.org
> >> re: EMPIRE-99 merge to trunk?
> >>
> >> There is one issue left causing a StringutilsTest to fail:
> >>
> >> this used to return empty string but now return "null"
> >> assertEquals("null",StringUtils.valueOf(null));
> >>
> >> This used to return empty string but is now "null"
> >> assertEquals("null",StringUtils.valueOf(new Object[]{}));
> >>
> >> I changed the test to accept the new behavior but this is dangerous
> in
> >> my eyes as this StringUtils is public and we might break existing
> >> code.
> >>
> >> Thanks Rainer for taking care of most of the refactorings, great we
> >> got there! So shall we merge the branch to trunk now?
> >>
> >> Greets,
> >> Francis
> >>
> >> --
> >> http://www.somatik.be
> >> Microsoft gives you windows, Linux gives you the whole house.
> >
>
>
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.
Re: EMPIRE-99 merge to trunk?
Posted by Francis De Brabandere <fr...@gmail.com>.
I already fixed the examples an the codegen. I'll take care of the merge.
Cheers,
Francis
On Tue, Aug 16, 2011 at 5:02 PM, Rainer Döbele <do...@esteam.de> wrote:
> Hi Franics,
>
> thanks. I noticed the StringUtils issue - but needed a break.
> It's a matter of taste what the String representation of null should be, and I am not sure whether I really want to keep it like this.
> For logging the value "null" is certainly better whereas for all other purposes an empty string is preferable.
>
> Most of the work for EMPIREDB-99 has been done.
> Only the codegen and three sample projects are missing but should be quite straigt forward to migrate.
>
> I have not been able to do a lot of testing, but I am confident that most code will work as before.
>
> I would appreciate a merge with the trunk and Francis if you want to do this, then please go ahead.
>
> I won't perform any more changes today.
>
> Regards
> Rainer
>
>
>> from: Francis De Brabandere [mailto:francisdb@gmail.com]
>> to: empire-db-dev@incubator.apache.org
>> re: EMPIRE-99 merge to trunk?
>>
>> There is one issue left causing a StringutilsTest to fail:
>>
>> this used to return empty string but now return "null"
>> assertEquals("null",StringUtils.valueOf(null));
>>
>> This used to return empty string but is now "null"
>> assertEquals("null",StringUtils.valueOf(new Object[]{}));
>>
>> I changed the test to accept the new behavior but this is dangerous in
>> my eyes as this StringUtils is public and we might break existing
>> code.
>>
>> Thanks Rainer for taking care of most of the refactorings, great we
>> got there! So shall we merge the branch to trunk now?
>>
>> Greets,
>> Francis
>>
>> --
>> http://www.somatik.be
>> Microsoft gives you windows, Linux gives you the whole house.
>
--
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.
re: EMPIRE-99 merge to trunk?
Posted by Rainer Döbele <do...@esteam.de>.
Hi Franics,
thanks. I noticed the StringUtils issue - but needed a break.
It's a matter of taste what the String representation of null should be, and I am not sure whether I really want to keep it like this.
For logging the value "null" is certainly better whereas for all other purposes an empty string is preferable.
Most of the work for EMPIREDB-99 has been done.
Only the codegen and three sample projects are missing but should be quite straigt forward to migrate.
I have not been able to do a lot of testing, but I am confident that most code will work as before.
I would appreciate a merge with the trunk and Francis if you want to do this, then please go ahead.
I won't perform any more changes today.
Regards
Rainer
> from: Francis De Brabandere [mailto:francisdb@gmail.com]
> to: empire-db-dev@incubator.apache.org
> re: EMPIRE-99 merge to trunk?
>
> There is one issue left causing a StringutilsTest to fail:
>
> this used to return empty string but now return "null"
> assertEquals("null",StringUtils.valueOf(null));
>
> This used to return empty string but is now "null"
> assertEquals("null",StringUtils.valueOf(new Object[]{}));
>
> I changed the test to accept the new behavior but this is dangerous in
> my eyes as this StringUtils is public and we might break existing
> code.
>
> Thanks Rainer for taking care of most of the refactorings, great we
> got there! So shall we merge the branch to trunk now?
>
> Greets,
> Francis
>
> --
> http://www.somatik.be
> Microsoft gives you windows, Linux gives you the whole house.