[GitHub] [hadoop] zhuxiangyi commented on a change in pull request #3553: HDFS-16273. RBF: RouterRpcFairnessPolicyController add availableHandl…

[GitBox <gi...@apache.org>]

zhuxiangyi commented on a change in pull request #3553:
URL: https://github.com/apache/hadoop/pull/3553#discussion_r742726950



##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/AbstractRouterRpcFairnessPolicyController.java
##########
@@ -75,4 +77,17 @@ protected void insertNameServiceWithPermits(String nsId, int maxPermits) {
   protected int getAvailablePermits(String nsId) {
     return this.permits.get(nsId).availablePermits();
   }
+
+  @Override
+  public String getAvailableHandlerOnPerNs() {
+    JSONObject json = new JSONObject();
+    for (Map.Entry<String, Semaphore> entry : permits.entrySet()) {
+      try {
+        json.put(entry.getKey(), entry.getValue().availablePermits());

Review comment:
       Updated.

##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/NoRouterRpcFairnessPolicyController.java
##########
@@ -46,4 +46,9 @@ public void releasePermit(String nsId) {
   public void shutdown() {
     // Nothing for now.
   }
+
+  @Override
+  public String getAvailableHandlerOnPerNs(){
+    return "N/A";

Review comment:
       Updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org