You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by zhan849 <gi...@git.apache.org> on 2018/04/16 16:59:43 UTC

[GitHub] helix pull request #181: [HELIX-690] batch message execution should not shar...

GitHub user zhan849 opened a pull request:

    https://github.com/apache/helix/pull/181

    [HELIX-690] batch message execution should not share same context

    In this PR, I added deep copy methods to NotificationContext so when processing messages in batch, different thread would not share the same notification context.
    
    This solves the problem that when processing BatchMessages, each thread will have their own current state delta to work on, so current states won't be messed up.
    
    Also modified some logs to make it more useful when debugging

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhan849/helix harry/batch-msg-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #181
    
----
commit bb7751b0f52aadcf04b7813fa3e99c8e266a3d0b
Author: Harry Zhang <zh...@...>
Date:   2018-04-16T16:55:43Z

    [HELIX-690] batch message execution should not share same context

----


---

[GitHub] helix pull request #181: [HELIX-690] batch message execution should not shar...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/181


---