You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Stan Lewis (JIRA)" <ji...@apache.org> on 2009/08/12 22:03:35 UTC
[jira] Created: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Specify multiple IRC channels in one URI for camel-irc
------------------------------------------------------
Key: CAMEL-1908
URL: https://issues.apache.org/activemq/browse/CAMEL-1908
Project: Apache Camel
Issue Type: Improvement
Affects Versions: 2.0-M3
Reporter: Stan Lewis
Fix For: Future
Attachments: patch.txt
Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-1908:
-------------------------------
Fix Version/s: (was: Future)
2.1.0
Thanks Stan will get the patch in the next release after 2.0 as its currently being build.
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53756#action_53756 ]
Stan Lewis commented on CAMEL-1908:
-----------------------------------
fixed it, sorry about that...
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt, patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53741#action_53741 ]
Claus Ibsen commented on CAMEL-1908:
------------------------------------
Applied patch with thanks to Stan Lewis
trunk: 807143.
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stan Lewis updated CAMEL-1908:
------------------------------
Attachment: patch.txt
Hey Claus,
Just realized I forgot to add the unit test before creating the patch, here's the test for this one.
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt, patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stan Lewis updated CAMEL-1908:
------------------------------
Attachment: patch.txt
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Fix For: Future
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-1908:
----------------------------------
Assignee: Claus Ibsen
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-1908.
------------------------------------
Resolution: Fixed
Patches applied with many thanks to Stan
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt, patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53755#action_53755 ]
Claus Ibsen commented on CAMEL-1908:
------------------------------------
Stan is the IRC documentation correct?
> irc:nick@host[:port]?channels=#channel1,@channel2,#channel3
Is the @channel2 a typo or what does it differ over using #channel2 instead?
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt, patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53742#action_53742 ]
Claus Ibsen commented on CAMEL-1908:
------------------------------------
Stan do you mind updating the camel-irc wiki page with this new option?
http://camel.apache.org/irc
When the documentation is updated we can close this ticket.
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53749#action_53749 ]
Stan Lewis commented on CAMEL-1908:
-----------------------------------
No at all, have done so. Thanks for applying the patch!
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-1908) Specify multiple IRC channels in one
URI for camel-irc
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stan Lewis updated CAMEL-1908:
------------------------------
Priority: Minor (was: Major)
> Specify multiple IRC channels in one URI for camel-irc
> ------------------------------------------------------
>
> Key: CAMEL-1908
> URL: https://issues.apache.org/activemq/browse/CAMEL-1908
> Project: Apache Camel
> Issue Type: Improvement
> Affects Versions: 2.0-M3
> Reporter: Stan Lewis
> Priority: Minor
> Fix For: Future
>
> Attachments: patch.txt
>
>
> Currently there's no way to specify more than one IRC channel in a camel-irc URI, the code explicitly checks for #blah to be in the URI fragment. This patch maintains the existing URI format but also adds a "channels" option as well as a comma-separated list of channels. I've also modified the producer to pay attention to the "irc.target" header, if that's not set then messages go to all channels the producer is connected to.
> Have modified the IrcPrivmsgTest to take advantage of this and added a multiple channel test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.