[jira] [Reopened] (VCL-764) Database changes for VCL 2.4

["Andy Kurth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/VCL-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Kurth reopened VCL-764:
----------------------------

I found a bug in RC2 which causes VMware-based reservations to fail if the stock VM profiles are used.  The bug was tricky to track down because the information written to vcld.log did not explain what the underlying problem was:

bq. VMware.pm:check_vmhost_disk_space|2213|failed to determine additional bytes required for the vmx and vmdk directories on VM host

The actual problem stems from this line in {{get_image_size_bytes}}:
bq. my $vmprofile_vmdisk = $self->data->get_vmhost_profile_vmdisk() || return;

In vcl.sql, the insert statement for the vmprofile table specifies _'localdisk'_ and _'networkdisk'_ for the vmprofile.vmdisk column.  This column uses the enum column type and the valid values were changed to _'dedicated'_ or _'shared'_ in a previous release.  The insert statements succeed but the vmdisk column gets set to a blank value.  Because of this, {{get_vmhost_profile_vmdisk}} returns false which causes {{check_vmhost_disk_space}} to fail.

> Database changes for VCL 2.4
> ----------------------------
>
>                 Key: VCL-764
>                 URL: https://issues.apache.org/jira/browse/VCL-764
>             Project: VCL
>          Issue Type: Improvement
>          Components: database
>    Affects Versions: 2.3.2
>            Reporter: Andy Kurth
>             Fix For: 2.4
>
>
> This is a catchall issue to track database changes for VCL 2.4 which aren't directly related to another issue.
> We really need to rework the database update process when upgrading VCL versions.  update-vcl.sql is difficult to manage and keep in sync with vcl.sql.  A single Perl script could be written which could be used for both fresh installs and updates.
> For fresh installs, it could simply import the vcl.sql file.
> For updates, it could query the existing database in order to determine if table definitions match vcl.sql and then execute an "alter" statement.  This will be much easier to code than the current stored procedures in update-vcl.sql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)