You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/08 02:09:09 UTC
Review Request 16715: showing start/stop time for tasks of completed
frameworks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
showing start/stop time for tasks of completed frameworks
Diffs
-----
src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
Diff: https://reviews.apache.org/r/16715/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 9, 2014, 9:28 p.m., Benjamin Hindman wrote:
> > src/webui/master/static/js/controllers.js, line 184
> > <https://reviews.apache.org/r/16715/diff/3/?file=418333#file418333line184>
> >
> > Is 'setTaskStatus' the right name here? Factoring this code out looks great but the name seems a bit weird (it appears to actually be setting the task's executor ID and start/finish time, not setting it's TaskStatus).
Good point, I forgot that status was already in use for something else.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/#review31461
-----------------------------------------------------------
On Jan. 8, 2014, 1:51 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16715/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:51 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> showing start/stop time for tasks of completed frameworks
>
> Review: http://reviews.apache.org/r/16715
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
>
> Diff: https://reviews.apache.org/r/16715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/#review31461
-----------------------------------------------------------
Ship it!
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/16715/#comment59957>
Is 'setTaskStatus' the right name here? Factoring this code out looks great but the name seems a bit weird (it appears to actually be setting the task's executor ID and start/finish time, not setting it's TaskStatus).
- Benjamin Hindman
On Jan. 8, 2014, 1:51 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16715/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:51 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> showing start/stop time for tasks of completed frameworks
>
> Review: http://reviews.apache.org/r/16715
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
>
> Diff: https://reviews.apache.org/r/16715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/#review31482
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 9, 2014, 10:54 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16715/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:54 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> showing start/stop time for tasks of completed frameworks
>
> Review: http://reviews.apache.org/r/16715
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
>
> Diff: https://reviews.apache.org/r/16715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/#review31524
-----------------------------------------------------------
Submitted.
- Ross Allen
On Jan. 9, 2014, 10:54 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16715/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:54 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> showing start/stop time for tasks of completed frameworks
>
> Review: http://reviews.apache.org/r/16715
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
>
> Diff: https://reviews.apache.org/r/16715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/
-----------------------------------------------------------
(Updated Jan. 9, 2014, 10:54 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
showing start/stop time for tasks of completed frameworks
Review: http://reviews.apache.org/r/16715
Diffs (updated)
-----
src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
Diff: https://reviews.apache.org/r/16715/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/#review31332
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Jan. 8, 2014, 1:51 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16715/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:51 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> showing start/stop time for tasks of completed frameworks
>
> Review: http://reviews.apache.org/r/16715
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
>
> Diff: https://reviews.apache.org/r/16715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:51 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
showing start/stop time for tasks of completed frameworks
Review: http://reviews.apache.org/r/16715
Diffs (updated)
-----
src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
Diff: https://reviews.apache.org/r/16715/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:44 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description (updated)
-------
showing start/stop time for tasks of completed frameworks
Review: http://reviews.apache.org/r/16715
Diffs (updated)
-----
src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
Diff: https://reviews.apache.org/r/16715/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/#review31331
-----------------------------------------------------------
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/16715/#comment59805>
Could this be something like `setTaskStatus` since it is modifying the argument passed to it? `getTaskStatus` sounds like it has no side effects.
- Ross Allen
On Jan. 8, 2014, 1:14 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16715/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 1:14 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> showing start/stop time for tasks of completed frameworks
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
>
> Diff: https://reviews.apache.org/r/16715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16715: showing start/stop time for tasks of completed
frameworks
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16715/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 1:14 a.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
showing start/stop time for tasks of completed frameworks
Diffs
-----
src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9
Diff: https://reviews.apache.org/r/16715/diff/
Testing
-------
Thanks,
Thomas Rampelberg