[jira] [Commented] (CALCITE-1883) HepPlanner should force garbage collect whenever a root registered

["Ted Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088379#comment-16088379 ] 

Ted Xu commented on CALCITE-1883:
---------------------------------

[~julianhyde] I've issued a pull request here: https://github.com/apache/calcite/pull/497

I'm not sure if the fix (leveraging the idea of number of transformations) is good enough, but you can reproduce the bug from that test case.

> HepPlanner should force garbage collect whenever a root registered
> ------------------------------------------------------------------
>
>                 Key: CALCITE-1883
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1883
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Ted Xu
>            Assignee: Julian Hyde
>
> Currently HepPlanner#collectGarbage() will skip if there is no new transform since last GC. If HepPlanner is reused, it is common case that no transform is applied after last cheapest plan is built while before next round of optimize is kicked off.
> This may break HepPlanner because the garbage is probably not a graph after HepPlanner#buildFinalPlan .
> I'll try if I can create a reproduce case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)