You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/07/08 18:22:04 UTC

Review Request 71033: Moved the Docker executor declaration into a header.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/
-----------------------------------------------------------

Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
    https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
-------

This moves the declaration of the Docker executor into the
Docker executor header file and moves the code for the Docker
executor binary into a new launcher implementation file.

This change will enable the Mesos executor driver
implementation to make use of the `DockerExecutor` symbol.


Diffs
-----

  src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/launcher/docker_executor.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71033/diff/1/


Testing
-------

Details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 71033: Moved the Docker executor declaration into a header.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/#review216481
-----------------------------------------------------------


Ship it!




Ship It!

- Benno Evers


On July 8, 2019, 6:22 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71033/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 6:22 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
>     https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves the declaration of the Docker executor into the
> Docker executor header file and moves the code for the Docker
> executor binary into a new launcher implementation file.
> 
> This change will enable the Mesos executor driver
> implementation to make use of the `DockerExecutor` symbol.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/launcher/docker_executor.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71033/diff/1/
> 
> 
> Testing
> -------
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71033: Moved the Docker executor declaration into a header.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/#review216620
-----------------------------------------------------------


Fix it, then Ship it!





src/Makefile.am
Lines 1092 (patched)
<https://reviews.apache.org/r/71033/#comment303834>

    This is missing the related CMake change.
    
    In src/CMakeLists.txts:
    ```
     set(DOCKER_SRC
       docker/docker.cpp
    +  docker/executor.cpp
       docker/spec.cpp)
    ```



src/Makefile.am
Line 1812 (original), 1813 (patched)
<https://reviews.apache.org/r/71033/#comment303833>

    This is missing the related CMake changes.
    
    * Delete src/docker/CMakeLists.txt
    
    * Add this to src/launcher/CMakeLists.txt:
    ```
    # THE DOCKER EXECUTOR EXECUTABLE.
    #################################
    add_executable(mesos-docker-executor docker_executor.cpp)
    target_link_libraries(mesos-docker-executor PRIVATE mesos)
    ```


- Joseph Wu


On July 8, 2019, 11:22 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71033/
> -----------------------------------------------------------
> 
> (Updated July 8, 2019, 11:22 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
>     https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves the declaration of the Docker executor into the
> Docker executor header file and moves the code for the Docker
> executor binary into a new launcher implementation file.
> 
> This change will enable the Mesos executor driver
> implementation to make use of the `DockerExecutor` symbol.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/launcher/docker_executor.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71033/diff/1/
> 
> 
> Testing
> -------
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71033: Moved the Docker executor declaration into a header.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/#review216866
-----------------------------------------------------------


Fix it, then Ship it!




Just fix this line up before commit.


src/CMakeLists.txt
Line 647 (original), 648 (patched)
<https://reviews.apache.org/r/71033/#comment304116>

    I forgot about this line in my previous CMake-related comment.  Since the file in here is now deleted, this line can go too.


- Joseph Wu


On July 25, 2019, 12:24 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71033/
> -----------------------------------------------------------
> 
> (Updated July 25, 2019, 12:24 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.
> 
> 
> Bugs: MESOS-9853
>     https://issues.apache.org/jira/browse/MESOS-9853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This moves the declaration of the Docker executor into the
> Docker executor header file and moves the code for the Docker
> executor binary into a new launcher implementation file.
> 
> This change will enable the Mesos executor driver
> implementation to make use of the `DockerExecutor` symbol.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
>   src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
>   src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
>   src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
>   src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
>   src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
>   src/launcher/docker_executor.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71033/diff/2/
> 
> 
> Testing
> -------
> 
> Details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 71033: Moved the Docker executor declaration into a header.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/
-----------------------------------------------------------

(Updated July 25, 2019, 8:31 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
    https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
-------

This moves the declaration of the Docker executor into the
Docker executor header file and moves the code for the Docker
executor binary into a new launcher implementation file.

This change will enable the Mesos executor driver
implementation to make use of the `DockerExecutor` symbol.


Diffs (updated)
-----

  src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
  src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
  src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
  src/launcher/docker_executor.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71033/diff/3/

Changes: https://reviews.apache.org/r/71033/diff/2-3/


Testing
-------

Details at the end of this chain.


Thanks,

Greg Mann

Re: Review Request 71033: Moved the Docker executor declaration into a header.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/
-----------------------------------------------------------

(Updated July 25, 2019, 7:24 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
    https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
-------

This moves the declaration of the Docker executor into the
Docker executor header file and moves the code for the Docker
executor binary into a new launcher implementation file.

This change will enable the Mesos executor driver
implementation to make use of the `DockerExecutor` symbol.


Diffs (updated)
-----

  src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
  src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
  src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
  src/launcher/docker_executor.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71033/diff/2/

Changes: https://reviews.apache.org/r/71033/diff/1-2/


Testing
-------

Details at the end of this chain.


Thanks,

Greg Mann