You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2020/04/02 11:10:34 UTC
[kudu-CR] [ksck] fix conflicting states in VerifyTablet
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15637
Change subject: [ksck] fix conflicting_states in VerifyTablet
......................................................................
[ksck] fix conflicting_states in VerifyTablet
The value of conflicting_states is calculated repeatedly,
this patch fixes it.
Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/15637/1
--
To view, visit http://gerrit.cloudera.org:8080/15637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
Gerrit-Change-Number: 15637
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [ksck] fix conflicting states in VerifyTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15637 )
Change subject: [ksck] fix conflicting_states in VerifyTablet
......................................................................
Patch Set 1: Verified+1
unrelated test failure in HmsSentryConfigurations/MasterFailoverTest.TestMasterPermanentFailure/2
--
To view, visit http://gerrit.cloudera.org:8080/15637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
Gerrit-Change-Number: 15637
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Apr 2020 14:31:03 +0000
Gerrit-HasComments: No
[kudu-CR] [ksck] fix conflicting states in VerifyTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15637 )
Change subject: [ksck] fix conflicting_states in VerifyTablet
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
Gerrit-Change-Number: 15637
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [ksck] fix conflicting states in VerifyTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15637 )
Change subject: [ksck] fix conflicting_states in VerifyTablet
......................................................................
[ksck] fix conflicting_states in VerifyTablet
The value of conflicting_states is calculated repeatedly,
this patch fixes it.
Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
Reviewed-on: http://gerrit.cloudera.org:8080/15637
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
Gerrit-Change-Number: 15637
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [ksck] fix conflicting states in VerifyTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15637 )
Change subject: [ksck] fix conflicting_states in VerifyTablet
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15637/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15637/1//COMMIT_MSG@9
PS1, Line 9: calculated repeatedly
Good catch!
--
To view, visit http://gerrit.cloudera.org:8080/15637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8475ee34cd7957c3c02159dd2099c1179f1ea12
Gerrit-Change-Number: 15637
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Apr 2020 14:30:52 +0000
Gerrit-HasComments: Yes