You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Nicolas Helleringer (JIRA)" <ji...@apache.org> on 2009/10/01 13:04:23 UTC

[jira] Created: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Rework (Float)LatLng implementation and distance calculation
------------------------------------------------------------

                 Key: LUCENE-1934
                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
             Project: Lucene - Java
          Issue Type: Improvement
          Components: contrib/spatial
    Affects Versions: 2.9
            Reporter: Nicolas Helleringer
            Priority: Minor


Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761193#action_12761193 ] 

Michael McCandless commented on LUCENE-1934:
--------------------------------------------

Note that there is something of a rework pending on contrib/spatial -- see http://lucene.markmail.org/message/4gaajqmhuxpwla7c -- maybe sync up w/ Chris to make sure this patch and his work fit together?



> Rework (Float)LatLng implementation and distance calculation
> ------------------------------------------------------------
>
>                 Key: LUCENE-1934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: Nicolas Helleringer
>            Priority: Minor
>         Attachments: LUCENE-1934.patch
>
>
> Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Helleringer updated LUCENE-1934:
----------------------------------------

    Attachment: LUCENE-1934.patch

Initial release of path :

- Removed loop for % use in longitude normalisation
- Recoded the Maths around distance calculation using well know implementation (ref: http://www.movable-type.co.uk/scripts/latlong.html)
- Changed UnitTest on doubles to use precision instead of exact comparaison (1e-4 of a mile precision)
- Introduced and spread the use of static initialized constants

May need some more work around class def and methods (used/not, static/not, etc ..)

> Rework (Float)LatLng implementation and distance calculation
> ------------------------------------------------------------
>
>                 Key: LUCENE-1934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: Nicolas Helleringer
>            Priority: Minor
>         Attachments: LUCENE-1934.patch
>
>
> Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782873#action_12782873 ] 

Nicolas Helleringer commented on LUCENE-1934:
---------------------------------------------

As Chris work is being released outside Lucene Apache project (http://www.jteam.nl/news/spatialsolr), should we consider this patch to be re evaluated to commit ?

> Rework (Float)LatLng implementation and distance calculation
> ------------------------------------------------------------
>
>                 Key: LUCENE-1934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: Nicolas Helleringer
>            Priority: Minor
>         Attachments: LUCENE-1934.patch
>
>
> Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Helleringer updated LUCENE-1934:
----------------------------------------

    Lucene Fields: [Patch Available]  (was: [New])

> Rework (Float)LatLng implementation and distance calculation
> ------------------------------------------------------------
>
>                 Key: LUCENE-1934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: Nicolas Helleringer
>            Priority: Minor
>         Attachments: LUCENE-1934.patch
>
>
> Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761171#action_12761171 ] 

Nicolas Helleringer commented on LUCENE-1934:
---------------------------------------------

Forgot :

- Removed local implementation of a degree to radian converter. Used Math.toRadians instead.

> Rework (Float)LatLng implementation and distance calculation
> ------------------------------------------------------------
>
>                 Key: LUCENE-1934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: Nicolas Helleringer
>            Priority: Minor
>         Attachments: LUCENE-1934.patch
>
>
> Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1934) Rework (Float)LatLng implementation and distance calculation

Posted by "Nicolas Helleringer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855944#action_12855944 ] 

Nicolas Helleringer commented on LUCENE-1934:
---------------------------------------------

This has to be reworked when LUCENE-2359 and LUCENE-2366 will be closed to match code produced there.

> Rework (Float)LatLng implementation and distance calculation
> ------------------------------------------------------------
>
>                 Key: LUCENE-1934
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1934
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 2.9
>            Reporter: Nicolas Helleringer
>            Priority: Minor
>         Attachments: LUCENE-1934.patch
>
>
> Clean up of the code and normalisation of the distance calculation to standard

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org